Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

add missing foreign language pages under cdp #1864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

@alaahong
Copy link
Member

@alaahong alaahong commented Aug 17, 2024 •
edited by qodo-merge-pro bot
Loading

User description

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

Documentation

Description

  • Added Japanese, Portuguese, and Chinese translations for Chrome DevTools Protocol (CDP) documentation.
  • Included examples for using CDP with Selenium in multiple programming languages.
  • Provided information on CDP's temporary support until WebDriver BiDi is implemented.
  • Added specific sections for logging, network, and script features using CDP.

Changes walkthrough 📝

Relevant files
Documentation
12 files
_index.ja.md
Add Japanese translation for CDP documentation

website_and_docs/content/documentation/webdriver/bidi/cdp/_index.ja.md

  • Added Japanese translation for Chrome DevTools Protocol documentation.
  • Included examples for using CDP with Selenium in multiple languages.
  • Provided information on CDP's temporary support until WebDriver BiDi
    is implemented.
    • +82/-0
    _index.pt-br.md
    Add Portuguese translation for CDP documentation

    website_and_docs/content/documentation/webdriver/bidi/cdp/_index.pt-br.md

  • Added Portuguese translation for Chrome DevTools Protocol
    documentation.
  • Included examples for using CDP with Selenium in multiple languages.
  • Provided information on CDP's temporary support until WebDriver BiDi
    is implemented.
    • +82/-0
    _index.zh-cn.md
    Add translation warning for Chinese CDP documentation

    website_and_docs/content/documentation/webdriver/bidi/cdp/_index.zh-cn.md

    • Added warning about translation from English to Chinese.
    +9/-0
    logging.ja.md
    Add Japanese translation for CDP logging features

    website_and_docs/content/documentation/webdriver/bidi/cdp/logging.ja.md

  • Added Japanese translation for CDP logging features.
  • Included examples for console logs and JavaScript exceptions.
    • +68/-0
    logging.pt-br.md
    Add Portuguese translation for CDP logging features

    website_and_docs/content/documentation/webdriver/bidi/cdp/logging.pt-br.md

  • Added Portuguese translation for CDP logging features.
  • Included examples for console logs and JavaScript exceptions.
    • +68/-0
    logging.zh-cn.md
    Add Chinese translation for CDP logging features

    website_and_docs/content/documentation/webdriver/bidi/cdp/logging.zh-cn.md

  • Added Chinese translation for CDP logging features.
  • Included examples for console logs and JavaScript exceptions.
    • +68/-0
    network.ja.md
    Add Japanese translation for CDP network features

    website_and_docs/content/documentation/webdriver/bidi/cdp/network.ja.md

  • Added Japanese translation for CDP network features.
  • Included examples for network interception and performance metrics.
    • +196/-0
    network.pt-br.md
    Add Portuguese translation for CDP network features

    website_and_docs/content/documentation/webdriver/bidi/cdp/network.pt-br.md

  • Added Portuguese translation for CDP network features.
  • Included examples for network interception and performance metrics.
    • +196/-0
    network.zh-cn.md
    Add Chinese translation for CDP network features

    website_and_docs/content/documentation/webdriver/bidi/cdp/network.zh-cn.md

  • Added Chinese translation for CDP network features.
  • Included examples for network interception and performance metrics.
    • +196/-0
    script.ja.md
    Add Japanese translation for CDP script features

    website_and_docs/content/documentation/webdriver/bidi/cdp/script.ja.md

  • Added Japanese translation for CDP script features.
  • Included examples for script pinning and DOM mutation handlers.
    • +68/-0
    script.pt-br.md
    Add Portuguese translation for CDP script features

    website_and_docs/content/documentation/webdriver/bidi/cdp/script.pt-br.md

  • Added Portuguese translation for CDP script features.
  • Included examples for script pinning and DOM mutation handlers.
    • +68/-0
    script.zh-cn.md
    Add Chinese translation for CDP script features

    website_and_docs/content/documentation/webdriver/bidi/cdp/script.zh-cn.md

  • Added Chinese translation for CDP script features.
  • Included examples for script pinning and DOM mutation handlers.
    • +68/-0

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    Copy link

    netlify bot commented Aug 17, 2024

    👷 Deploy request for selenium-dev pending review.

    Visit the deploys page to approve it

    Name Link
    🔨 Latest commit db02573

    @qodo-merge-pro qodo-merge-pro bot added documentation Improvements or additions to documentation Review effort [1-5]: 2 labels Aug 17, 2024
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Key issues to review

    Translation Inconsistency
    The page info states it's being translated to Japanese, but the content is in English.

    Translation Inconsistency
    The page info states it's being translated to Japanese, but this is the Portuguese file.

    Translation Inconsistency
    The page info states it's being translated to Japanese, but this is the Portuguese file.

    Translation Inconsistency
    The page info states it's being translated to Japanese, but this is the Portuguese file.

    Copy link
    Contributor

    PR Code Suggestions ✨

    CategorySuggestion Score
    Accuracy
    Correct the target language in the translation warning

    The language mentioned in the translation warning is incorrect. It should be
    Portuguese (pt-br) instead of Japanese.

    website_and_docs/content/documentation/webdriver/bidi/cdp/network.pt-br.md [9-16] 

     {{% pageinfo color="warning" %}}
 <p class="lead">
 <i class="fas fa-language d-4"></i>
- Page being translated from
- English to Japanese. Do you speak Japanese? Help us to translate
+ Page being translated from English to Portuguese (Brazilian).
+ Do you speak Portuguese? Help us to translate
 it by sending us pull requests!
 </p>
 {{% /pageinfo %}}
    • Apply this suggestion
    Suggestion importance[1-10]: 9

    Why: Correcting the language in the translation warning is crucial for accuracy and user understanding, making this a high-priority fix.

    		9
    Content accuracy
    Correct the language mentioned in the translation notice to match the file's language

    Update the language mentioned in the translation notice from Japanese to Portuguese
    (Brazilian), as this is the pt-br version of the file.

    website_and_docs/content/documentation/webdriver/bidi/cdp/logging.pt-br.md [12-14] 

     Page being translated from
-English to Japanese. Do you speak Japanese? Help us to translate
+English to Portuguese (Brazilian). Do you speak Portuguese? Help us to translate
 it by sending us pull requests!
    • Apply this suggestion
    Suggestion importance[1-10]: 9

    Why: The suggestion correctly identifies a mismatch in the language notice, which is crucial for content accuracy and user understanding in the pt-br file.

    		9
    Consistency
    Adjust the translation warning to match the target language file

    The language mentioned in the translation warning is inconsistent with the file
    name. It should be Japanese instead of English to Japanese.

    website_and_docs/content/documentation/webdriver/bidi/cdp/_index.ja.md [18-25] 

     {{% pageinfo color="warning" %}}
 <p class="lead">
- <i class="fas fa-language d-4"></i> 
- Page being translated from English to Japanese. 
- Do you speak Japanese? Help us to translate
- it by sending us pull requests!
+ <i class="fas fa-language d-4"></i>
+ This page is in Japanese. Can you help improve the translation?
+ If you speak Japanese, please send us pull requests!
 </p>
 {{% /pageinfo %}}
    • Apply this suggestion
    Suggestion importance[1-10]: 8

    Why: Adjusting the translation warning to match the target language file improves clarity and consistency, which is important for user comprehension.

    		8
    Standardize the translation warning template across all language versions

    The page info warning about translation is inconsistent across the files. Consider
    using a consistent template for all language versions.

    website_and_docs/content/documentation/webdriver/bidi/cdp/network.ja.md [9-16] 

     {{% pageinfo color="warning" %}}
 <p class="lead">
- <i class="fas fa-language d-4"></i> 
- Page being translated from English to Japanese. 
- Do you speak Japanese? Help us to translate
- it by sending us pull requests!
+ <i class="fas fa-language d-4"></i>
+ Page being translated from English to Japanese.
+ Do you speak Japanese? Help us to translate
+ it by sending us pull requests!
 </p>
 {{% /pageinfo %}}
    • Apply this suggestion
    Suggestion importance[1-10]: 7

    Why: The suggestion improves consistency across documentation files, which enhances readability and maintainability, but it is not critical to functionality.

    		7
    Localization
    Translate the metadata fields to the target language of the file

    Consider translating the title, link title, and description to Chinese to maintain
    consistency with the file's intended language.

    website_and_docs/content/documentation/webdriver/bidi/cdp/logging.zh-cn.md [2-6] 

    -title: "Chrome DevTools Logging Features"
-linkTitle: "Logging"
+title: "Chrome开发者工具日志功能"
+linkTitle: "日志记录"
 weight: 2
 description: >
- Logging features using CDP.
+ 使用CDP的日志记录功能。
    • Apply this suggestion
    Suggestion importance[1-10]: 8

    Why: Translating the metadata fields to Chinese improves localization and consistency with the rest of the document, enhancing user experience for Chinese readers.

    		8
    Translate the newly added content to the target language of the file

    Consider translating the newly added translation notice to Chinese, as this is the
    zh-cn version of the file.

    website_and_docs/content/documentation/webdriver/bidi/cdp/_index.zh-cn.md [18-25] 

     {{% pageinfo color="warning" %}}
 <p class="lead">
 <i class="fas fa-language d-4"></i>
- Page being translated from
- English to Chinese. Do you speak Chinese? Help us to translate
- it by sending us pull requests!
+ 本页正在从英文翻译成中文。您会说中文吗?请帮助我们翻译,
+ 向我们发送拉取请求!
 </p>
 {{% /pageinfo %}}
    • Apply this suggestion
    Suggestion importance[1-10]: 8

    Why: Translating the notice to Chinese aligns with the document's language, improving readability and accessibility for the intended audience.

    		8

    @alaahong alaahong merged commit 36b16c7 into SeleniumHQ:trunk Aug 17, 2024
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    No reviews

    Assignees

    No one assigned

    Labels

    documentation Improvements or additions to documentation Review effort [1-5]: 2

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    1 participant

    AltStyle によって変換されたページ (->オリジナル) /