Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

update feature/feature/options——20240629 #1788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alaahong merged 1 commit into SeleniumHQ:trunk from alaahong:feature/options_20240629
Jun 29, 2024

Conversation

@alaahong
Copy link
Member

@alaahong alaahong commented Jun 29, 2024 •
edited by qodo-merge-pro bot
Loading

User description

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Update options in Chinese

Description

Motivation and Context

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

Documentation

Description

  • Improved the Chinese translation for the browserName section to clarify that the browser name is set by default when using an Options class instance.
  • Enhanced the Chinese translation for the browserVersion section to explain that this capability is optional and used to set the available browser version at the remote end. Added details about automatic download by Selenium Manager if the version is not found on the system.

Changes walkthrough 📝

Relevant files
Documentation
options.zh-cn.md
Update Chinese translation for browser options documentation

website_and_docs/content/documentation/webdriver/drivers/options.zh-cn.md

  • Improved translation of browser name and version sections.
  • Added more detailed explanations for browser version capability.
    • +5/-4

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    Copy link

    netlify bot commented Jun 29, 2024

    👷 Deploy request for selenium-dev pending review.

    Visit the deploys page to approve it

    Name Link
    🔨 Latest commit 7ec6ac0

    @qodo-merge-pro qodo-merge-pro bot added the documentation Improvements or additions to documentation label Jun 29, 2024
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review [1-5] 1
    🧪 Relevant tests No
    🔒 Security concerns No
    ⚡ Key issues to review None

    Copy link
    Contributor

    PR Code Suggestions ✨

    CategorySuggestion Score
    Enhancement
    Add a period at the end of the sentence to maintain consistency and professionalism in documentation

    Consider adding a period at the end of the sentence for consistency with other
    documentation standards.

    website_and_docs/content/documentation/webdriver/drivers/options.zh-cn.md [33] 

    -默认情况下,使用 Options 类实例时会设置浏览器名称
+默认情况下,使用 Options 类实例时会设置浏览器名称。
    • Apply this suggestion
    Suggestion importance[1-10]: 9

    Why: Adding a period at the end of the sentence improves consistency and professionalism in the documentation. This is a minor but important enhancement for maintaining documentation standards.

    		9
    Readability
    Split a complex sentence into two simpler sentences to improve readability

    Consider breaking the sentence into two for clarity and ease of reading, especially since
    the sentence contains multiple clauses.

    website_and_docs/content/documentation/webdriver/drivers/options.zh-cn.md [59-61] 

    -此功能是可选的,用于在远程端设置可用的浏览器版本. 在最新版本的 Selenium 中,如果在系统上找不到该版本, 它将被 [Selenium Manager]({{< ref "../../selenium_manager" >}}) 自动下载
+此功能是可选的,用于在远程端设置可用的浏览器版本。在最新版本的 Selenium 中,如果在系统上找不到该版本,它将被 [Selenium Manager]({{< ref "../../selenium_manager" >}}) 自动下载。
    • Apply this suggestion
    Suggestion importance[1-10]: 8

    Why: Splitting the complex sentence into two simpler sentences enhances readability and clarity, especially for non-native readers. This is a valuable improvement for documentation.

    		8

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    No reviews

    Assignees

    No one assigned

    Labels

    documentation Improvements or additions to documentation Review effort [1-5]: 1

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    1 participant

    AltStyle によって変換されたページ (->オリジナル) /