Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Include MIXED output in SM doc #1781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harsha509 merged 2 commits into trunk from sm_doc_mixed
Jun 27, 2024
Merged

Include MIXED output in SM doc #1781

harsha509 merged 2 commits into trunk from sm_doc_mixed
Jun 27, 2024

Conversation

@bonigarcia
Copy link
Member

@bonigarcia bonigarcia commented Jun 24, 2024 •
edited by qodo-merge-pro bot
Loading

User description

Description

This PR updates the Selenium Manager pages to include the MIXED output.

Motivation and Context

This change was published in SM 0.4.22, part of the 4.22 Selenium release.

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

documentation

Description

  • Updated Selenium Manager documentation to include the new MIXED output type.
  • The MIXED output type sends INFO, WARN, DEBUG, etc. to stderr and minimal JSON to stdout.
  • Changes applied to English, Japanese, Brazilian Portuguese, and Simplified Chinese documentation.

Changes walkthrough 📝

Relevant files
Documentation
selenium_manager.en.md
Add `MIXED` output type to Selenium Manager documentation (EN)

website_and_docs/content/documentation/selenium_manager.en.md

  • Added MIXED output type to the documentation table.
  • Described MIXED output type functionality.
    • +1/-1
    selenium_manager.ja.md
    Add `MIXED` output type to Selenium Manager documentation (JA)

    website_and_docs/content/documentation/selenium_manager.ja.md

  • Added MIXED output type to the documentation table.
  • Described MIXED output type functionality.
    • +1/-1
    selenium_manager.pt-br.md
    Add `MIXED` output type to Selenium Manager documentation (PT-BR)

    website_and_docs/content/documentation/selenium_manager.pt-br.md

  • Added MIXED output type to the documentation table.
  • Described MIXED output type functionality.
    • +1/-1
    selenium_manager.zh-cn.md
    Add `MIXED` output type to Selenium Manager documentation (ZH-CN)

    website_and_docs/content/documentation/selenium_manager.zh-cn.md

  • Added MIXED output type to the documentation table.
  • Described MIXED output type functionality.
    • +1/-1

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    @qodo-merge-pro qodo-merge-pro bot added documentation Improvements or additions to documentation Review effort [1-5]: 2 labels Jun 24, 2024
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review [1-5] 2
    🧪 Relevant tests No
    🔒 Security concerns No
    ⚡ Key issues to review None

    Copy link
    Contributor

    PR Code Suggestions ✨

    CategorySuggestion Score
    Clarity
    Add clarification for the term "minimal JSON" in the MIXED output type description

    Consider adding a brief explanation for what "minimal JSON" means in the context of the
    MIXED output type to avoid any ambiguity for the readers.

    website_and_docs/content/documentation/selenium_manager.en.md [121] 

    -|`--output <OUTPUT>`|`output = "OUTPUT"`|`SE_OUTPUT=OUTPUT`|Output type: `LOGGER` (using `INFO`, `WARN`, etc.), `JSON` (custom JSON notation), `SHELL` (Unix-like), or `MIXED` (`INFO`, `WARN`, `DEBUG`, etc. to stderr and minimal `JSON` to stdout). Default: `LOGGER`|
+|`--output <OUTPUT>`|`output = "OUTPUT"`|`SE_OUTPUT=OUTPUT`|Output type: `LOGGER` (using `INFO`, `WARN`, etc.), `JSON` (custom JSON notation), `SHELL` (Unix-like), or `MIXED` (`INFO`, `WARN`, `DEBUG`, etc. to stderr and minimal `JSON` (only essential information) to stdout). Default: `LOGGER`|
    • Apply this suggestion
    Suggestion importance[1-10]: 7

    Why: The suggestion to clarify "minimal JSON" in the documentation is valuable for reader understanding, though it's not a critical issue.

    		7

    Copy link

    netlify bot commented Jun 24, 2024 •
    edited
    Loading

    ✅ Deploy Preview for selenium-dev ready!

    Name Link
    🔨 Latest commit d004d34
    🔍 Latest deploy log https://app.netlify.com/sites/selenium-dev/deploys/667d0f5841ce6500086bfd20
    😎 Deploy Preview https://deploy-preview-1781--selenium-dev.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    @harsha509 harsha509 merged commit 9980ce6 into trunk Jun 27, 2024
    @harsha509 harsha509 deleted the sm_doc_mixed branch June 27, 2024 07:06
    selenium-ci added a commit that referenced this pull request Jun 27, 2024 
    Co-authored-by: Sri Harsha <12621691+harsha509@users.noreply.github.com> 9980ce6
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @harsha509 harsha509 harsha509 approved these changes

    Assignees

    No one assigned

    Labels

    documentation Improvements or additions to documentation Review effort [1-5]: 2

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    AltStyle によって変換されたページ (->オリジナル) /