-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Release 4.22 Updates #1765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Release 4.22 Updates #1765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Reviewer Guide 🔍
⏱️ Estimated effort to review [1-5]
2
🧪 Relevant tests
No
🔒 Security concerns
No
⚡ Key issues to review
None
✅ Deploy Preview for selenium-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
PR Code Suggestions ✨
|
CI Failure Feedback 🧐
(Checks updated until commit 02b3af6)
Action: tests (macos, stable)
Failed stage: Run tests [❌]
Failed test name: Remote WebDriver starts remotely
Failure summary:
The action failed because multiple tests in the remote_webdriver_spec.rb file encountered a TypeError. Specifically:
Selenium::Server.get raised a TypeError indicating "no implicit conversion of String into Integer".
-
Remote WebDriver starts remotely-
Remote WebDriver uploads-
Remote WebDriver downloadsremote_webdriver_spec.rb file.Relevant error logs:
1: ##[group]Operating System 2: macOS ... 271: timeout_minutes: 20 272: max_attempts: 3 273: command: cd examples/ruby 274: bundle exec rspec 275: 276: retry_wait_seconds: 10 277: polling_interval_seconds: 1 278: warning_on_retry: true 279: continue_on_error: false ... 284: PATH: /Users/runner/.local/bin:/opt/homebrew/bin:/opt/homebrew/sbin:/Users/runner/.cargo/bin:/usr/local/opt/curl/bin:/usr/local/bin:/usr/local/sbin:/Users/runner/bin:/Users/runner/.yarn/bin:/Users/runner/Library/Android/sdk/tools:/Users/runner/Library/Android/sdk/platform-tools:/Library/Frameworks/Python.framework/Versions/Current/bin:/Library/Frameworks/Mono.framework/Versions/Current/Commands:/usr/bin:/bin:/usr/sbin:/sbin:/Users/runner/.dotnet/tools 285: JAVA_HOME: /Users/runner/hostedtoolcache/Java_Temurin-Hotspot_jdk/11.0.23-9/arm64/Contents/Home 286: JAVA_HOME_11_ARM64: /Users/runner/hostedtoolcache/Java_Temurin-Hotspot_jdk/11.0.23-9/arm64/Contents/Home 287: ##[endgroup] 288: ......*.........................................................................***...*************...*.....*........*FFF....*********************.................... 289: Pending: (Failures listed here are expected and do not affect your suite's status) 290: 1) Keys copy and paste 291: # Test guarded; Guarded by {:browser=>:chrome, :reason=>"https://bugs.chromium.org/p/chromedriver/issues/detail?id=4264"}; 292: Failure/Error: expect(driver.find_element(id: 'textInput').attribute('value')).to eq 'SeleniumSelenium!' ... 411: 40) Element Locators with relative locators finds near element 412: # These are reference following the documentation example 413: # ./spec/elements/locators_spec.rb:55 414: 41) Element Locators with relative locators chains relative locators 415: # These are reference following the documentation example 416: # ./spec/elements/locators_spec.rb:59 417: Failures: 418: 1) Remote WebDriver starts remotely 419: Got 0 failures and 2 other errors: 420: 1.1) Failure/Error: 421: Selenium::Server.get(:latest, 422: background: true, 423: args: %w[--selenium-manager true --enable-managed-downloads true]) 424: TypeError: 425: no implicit conversion of String into Integer 426: # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>' 427: # ./spec/drivers/remote_webdriver_spec.rb:16:in `block (2 levels) in <top (required)>' 428: 1.2) Failure/Error: 429: Selenium::Server.get(:latest, 430: background: true, 431: args: %w[--selenium-manager true --enable-managed-downloads true]) 432: TypeError: 433: no implicit conversion of String into Integer 434: # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>' 435: # ./spec/drivers/remote_webdriver_spec.rb:17:in `block (2 levels) in <top (required)>' 436: 2) Remote WebDriver uploads 437: Got 0 failures and 2 other errors: 438: 2.1) Failure/Error: 439: Selenium::Server.get(:latest, 440: background: true, 441: args: %w[--selenium-manager true --enable-managed-downloads true]) 442: TypeError: 443: no implicit conversion of String into Integer 444: # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>' 445: # ./spec/drivers/remote_webdriver_spec.rb:16:in `block (2 levels) in <top (required)>' 446: 2.2) Failure/Error: 447: Selenium::Server.get(:latest, 448: background: true, 449: args: %w[--selenium-manager true --enable-managed-downloads true]) 450: TypeError: 451: no implicit conversion of String into Integer 452: # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>' 453: # ./spec/drivers/remote_webdriver_spec.rb:17:in `block (2 levels) in <top (required)>' 454: 3) Remote WebDriver downloads 455: Got 0 failures and 2 other errors: 456: 3.1) Failure/Error: 457: Selenium::Server.get(:latest, 458: background: true, 459: args: %w[--selenium-manager true --enable-managed-downloads true]) 460: TypeError: 461: no implicit conversion of String into Integer 462: # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>' 463: # ./spec/drivers/remote_webdriver_spec.rb:16:in `block (2 levels) in <top (required)>' 464: 3.2) Failure/Error: 465: Selenium::Server.get(:latest, 466: background: true, 467: args: %w[--selenium-manager true --enable-managed-downloads true]) 468: TypeError: 469: no implicit conversion of String into Integer 470: # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>' 471: # ./spec/drivers/remote_webdriver_spec.rb:17:in `block (2 levels) in <top (required)>' 472: Finished in 6 minutes 30 seconds (files took 8.79 seconds to load) 473: 166 examples, 3 failures, 41 pending 474: Failed examples: 475: rspec ./spec/drivers/remote_webdriver_spec.rb:19 # Remote WebDriver starts remotely 476: rspec ./spec/drivers/remote_webdriver_spec.rb:26 # Remote WebDriver uploads 477: rspec ./spec/drivers/remote_webdriver_spec.rb:42 # Remote WebDriver downloads 478: ##[warning]Attempt 1 failed. Reason: Child_process exited with error code 1 479: ......*.........................................................................***...*************...*.....*........*FFF....*********************.................... 480: Pending: (Failures listed here are expected and do not affect your suite's status) 481: 1) Keys copy and paste 482: # Test guarded; Guarded by {:browser=>:chrome, :reason=>"https://bugs.chromium.org/p/chromedriver/issues/detail?id=4264"}; 483: Failure/Error: expect(driver.find_element(id: 'textInput').attribute('value')).to eq 'SeleniumSelenium!' ... 602: 40) Element Locators with relative locators finds near element 603: # These are reference following the documentation example 604: # ./spec/elements/locators_spec.rb:55 605: 41) Element Locators with relative locators chains relative locators 606: # These are reference following the documentation example 607: # ./spec/elements/locators_spec.rb:59 608: Failures: 609: 1) Remote WebDriver starts remotely 610: Got 0 failures and 2 other errors: 611: 1.1) Failure/Error: 612: Selenium::Server.get(:latest, 613: background: true, 614: args: %w[--selenium-manager true --enable-managed-downloads true]) 615: TypeError: 616: no implicit conversion of String into Integer 617: # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>' 618: # ./spec/drivers/remote_webdriver_spec.rb:16:in `block (2 levels) in <top (required)>' 619: 1.2) Failure/Error: 620: Selenium::Server.get(:latest, 621: background: true, 622: args: %w[--selenium-manager true --enable-managed-downloads true]) 623: TypeError: 624: no implicit conversion of String into Integer 625: # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>' 626: # ./spec/drivers/remote_webdriver_spec.rb:17:in `block (2 levels) in <top (required)>' 627: 2) Remote WebDriver uploads 628: Got 0 failures and 2 other errors: 629: 2.1) Failure/Error: 630: Selenium::Server.get(:latest, 631: background: true, 632: args: %w[--selenium-manager true --enable-managed-downloads true]) 633: TypeError: 634: no implicit conversion of String into Integer 635: # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>' 636: # ./spec/drivers/remote_webdriver_spec.rb:16:in `block (2 levels) in <top (required)>' 637: 2.2) Failure/Error: 638: Selenium::Server.get(:latest, 639: background: true, 640: args: %w[--selenium-manager true --enable-managed-downloads true]) 641: TypeError: 642: no implicit conversion of String into Integer 643: # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>' 644: # ./spec/drivers/remote_webdriver_spec.rb:17:in `block (2 levels) in <top (required)>' 645: 3) Remote WebDriver downloads 646: Got 0 failures and 2 other errors: 647: 3.1) Failure/Error: 648: Selenium::Server.get(:latest, 649: background: true, 650: args: %w[--selenium-manager true --enable-managed-downloads true]) 651: TypeError: 652: no implicit conversion of String into Integer 653: # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>' 654: # ./spec/drivers/remote_webdriver_spec.rb:16:in `block (2 levels) in <top (required)>' 655: 3.2) Failure/Error: 656: Selenium::Server.get(:latest, 657: background: true, 658: args: %w[--selenium-manager true --enable-managed-downloads true]) 659: TypeError: 660: no implicit conversion of String into Integer 661: # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>' 662: # ./spec/drivers/remote_webdriver_spec.rb:17:in `block (2 levels) in <top (required)>' 663: Finished in 6 minutes 6 seconds (files took 4.58 seconds to load) 664: 166 examples, 3 failures, 41 pending 665: Failed examples: 666: rspec ./spec/drivers/remote_webdriver_spec.rb:19 # Remote WebDriver starts remotely 667: rspec ./spec/drivers/remote_webdriver_spec.rb:26 # Remote WebDriver uploads 668: rspec ./spec/drivers/remote_webdriver_spec.rb:42 # Remote WebDriver downloads 669: ##[warning]Attempt 2 failed. Reason: Child_process exited with error code 1 670: ......*.........................................................................***...*************...*.....*........*FFF....*********************.................... 671: Pending: (Failures listed here are expected and do not affect your suite's status) 672: 1) Keys copy and paste 673: # Test guarded; Guarded by {:browser=>:chrome, :reason=>"https://bugs.chromium.org/p/chromedriver/issues/detail?id=4264"}; 674: Failure/Error: expect(driver.find_element(id: 'textInput').attribute('value')).to eq 'SeleniumSelenium!' ... 793: 40) Element Locators with relative locators finds near element 794: # These are reference following the documentation example 795: # ./spec/elements/locators_spec.rb:55 796: 41) Element Locators with relative locators chains relative locators 797: # These are reference following the documentation example 798: # ./spec/elements/locators_spec.rb:59 799: Failures: 800: 1) Remote WebDriver starts remotely 801: Got 0 failures and 2 other errors: 802: 1.1) Failure/Error: 803: Selenium::Server.get(:latest, 804: background: true, 805: args: %w[--selenium-manager true --enable-managed-downloads true]) 806: TypeError: 807: no implicit conversion of String into Integer 808: # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>' 809: # ./spec/drivers/remote_webdriver_spec.rb:16:in `block (2 levels) in <top (required)>' 810: 1.2) Failure/Error: 811: Selenium::Server.get(:latest, 812: background: true, 813: args: %w[--selenium-manager true --enable-managed-downloads true]) 814: TypeError: 815: no implicit conversion of String into Integer 816: # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>' 817: # ./spec/drivers/remote_webdriver_spec.rb:17:in `block (2 levels) in <top (required)>' 818: 2) Remote WebDriver uploads 819: Got 0 failures and 2 other errors: 820: 2.1) Failure/Error: 821: Selenium::Server.get(:latest, 822: background: true, 823: args: %w[--selenium-manager true --enable-managed-downloads true]) 824: TypeError: 825: no implicit conversion of String into Integer 826: # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>' 827: # ./spec/drivers/remote_webdriver_spec.rb:16:in `block (2 levels) in <top (required)>' 828: 2.2) Failure/Error: 829: Selenium::Server.get(:latest, 830: background: true, 831: args: %w[--selenium-manager true --enable-managed-downloads true]) 832: TypeError: 833: no implicit conversion of String into Integer 834: # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>' 835: # ./spec/drivers/remote_webdriver_spec.rb:17:in `block (2 levels) in <top (required)>' 836: 3) Remote WebDriver downloads 837: Got 0 failures and 2 other errors: 838: 3.1) Failure/Error: 839: Selenium::Server.get(:latest, 840: background: true, 841: args: %w[--selenium-manager true --enable-managed-downloads true]) 842: TypeError: 843: no implicit conversion of String into Integer 844: # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>' 845: # ./spec/drivers/remote_webdriver_spec.rb:16:in `block (2 levels) in <top (required)>' 846: 3.2) Failure/Error: 847: Selenium::Server.get(:latest, 848: background: true, 849: args: %w[--selenium-manager true --enable-managed-downloads true]) 850: TypeError: 851: no implicit conversion of String into Integer 852: # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>' 853: # ./spec/drivers/remote_webdriver_spec.rb:17:in `block (2 levels) in <top (required)>' 854: Finished in 5 minutes 21 seconds (files took 3.4 seconds to load) 855: 166 examples, 3 failures, 41 pending 856: Failed examples: 857: rspec ./spec/drivers/remote_webdriver_spec.rb:19 # Remote WebDriver starts remotely 858: rspec ./spec/drivers/remote_webdriver_spec.rb:26 # Remote WebDriver uploads 859: rspec ./spec/drivers/remote_webdriver_spec.rb:42 # Remote WebDriver downloads 860: ##[error]Final attempt failed. Child_process exited with error code 1
✨ CI feedback usage guide:
The CI feedback tool (/checks) automatically triggers when a PR has a failed check.
The tool analyzes the failed checks and provides several feedbacks:
- Failed stage
- Failed test name
- Failure summary
- Relevant error logs
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:
/checks "https://github.com/{repo_name}/actions/runs/{run_number}/job/{job_number}"
where {repo_name} is the name of the repository, {run_number} is the run number of the failed check, and {job_number} is the job number of the failed check.
Configuration options
enable_auto_checks_feedback- if set to true, the tool will automatically provide feedback when a check is failed. Default is true.excluded_checks_list- a list of checks to exclude from the feedback, for example: ["check1", "check2"]. Default is an empty list.enable_help_text- if set to true, the tool will provide a help message with the feedback. Default is true.persistent_comment- if set to true, the tool will overwrite a previous checks comment with the new feedback. Default is true.final_update_message- ifpersistent_commentis true and updating a previous checks message, the tool will also create a new message: "Persistent checks updated to latest commit". Default is true.
See more information about the checks tool in the docs.
@titusfortner
titusfortner
force-pushed
the
4_22
branch
from
June 24, 2024 14:24
ce4e0fc to
603cb0c
Compare
@titusfortner
titusfortner
changed the title
(削除) update example versions for 4.22 (削除ここまで)
(追記) Release 4.22 Updates (追記ここまで)
Jun 24, 2024
p0deje
p0deje
reviewed
Jun 24, 2024
pujagani
pujagani
requested changes
Jun 25, 2024
...and_docs/content/documentation/webdriver/bidirectional/webdriver_bidi/browsing_context.ja.md
Show resolved
Hide resolved
@titusfortner
titusfortner
force-pushed
the
4_22
branch
from
June 25, 2024 13:04
d8f5c5d to
738629d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Uh oh!
There was an error while loading. Please reload this page.
Description
Status
Still need to:
(削除) update translations (削除ここまで)(削除) put the low-level examples in Java and JS back (削除ここまで)Feedback Needed
Everything under here: https://deploy-preview-1765--selenium-dev.netlify.app/documentation/webdriver/bidi/
Including all this: https://deploy-preview-1765--selenium-dev.netlify.app/documentation/webdriver/bidi/cdp/
Motivation and Context
Selenium 4.22!
PR Type
enhancement
Description
Changes walkthrough 📝
SeleniumDocs.csproj
Update .NET Selenium package versions to 4.22.0examples/dotnet/SeleniumDocs/SeleniumDocs.csproj
Selenium.Supportpackage version to 4.22.0Selenium.WebDriverpackage version to 4.22.0pom.xml
Update Java Selenium version to 4.22.0examples/java/pom.xml
selenium.versionproperty to 4.22.0package-lock.json
Update JavaScript Selenium package version in package-lock.json to4.22.0examples/javascript/package-lock.json
selenium-webdriverpackage version to 4.22.0package.json
Update JavaScript Selenium package version in package.json to 4.22.0examples/javascript/package.json
selenium-webdriverpackage version to 4.22.0pom.xml
Update Kotlin Selenium version to 4.22.0examples/kotlin/pom.xml
selenium.versionproperty to 4.22.0requirements.txt
Update Python Selenium package version to 4.22.0examples/python/requirements.txt
seleniumpackage version to 4.22.0Gemfile
Update Ruby Selenium gem version to 4.22.0examples/ruby/Gemfile
selenium-webdrivergem version to 4.22.0