-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Upgrade selenium 4 ruby examples & rendering issue #1695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade selenium 4 ruby examples & rendering issue #1695
Conversation
...o expand_options_example_page
...o expand_options_example_page
...o expand_options_example_page
👷 Deploy request for selenium-dev pending review.Visit the deploys page to approve it
|
PR Description updated to latest commit (5ae210d)
- Copy walkthrough table to "Files Changed" Tab
PR Review
3, because the PR includes multiple changes in the Ruby WebDriver options tests and documentation updates across different language versions. The added tests cover various WebDriver configurations, which require careful review to ensure they are correctly implemented and align with Selenium's standards.
Yes
Possible Bug: The use of a hardcoded proxy server 'myproxy.com:8080' in the test 'sets the proxy' might not be ideal for all environments. Consider parameterizing this or using environment variables.
Code Redundancy: The URL 'https://www.selenium.dev/selenium/web/' is used repeatedly in multiple tests. It might be more efficient to define this URL once as a constant at the beginning of the test file to make future changes easier and reduce potential errors.
No
✨ Review tool usage guide:
Overview:
The review tool scans the PR code changes, and generates a PR review which includes several types of feedbacks, such as possible PR issues, security threats and relevant test in the PR. More feedbacks can be added by configuring the tool.
The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
- When commenting, to edit configurations related to the review tool (
pr_reviewersection), use the following template:
/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...
- With a configuration file, use the following template:
[pr_reviewer]
some_config1=...
some_config2=...
See the review usage page for a comprehensive guide on using this tool.
PR Code Suggestions
✨ Improve tool usage guide:Overview:
See the improve usage page for a comprehensive guide on using this tool. |
Hi @harsha509
Thank you for the help,
The conflicts are resolved and I also fixed the rendering of the proxy options in the docs
Let me know if everything else is needed and have a great weeekend
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @aguspe !
@harsha509 Thank you :) I will continue updating the ruby documentation today, have a nice day!
...deploy site] * Expand options documentation test and examples * Update timeouts examples * Update all navigations * Update options after updating the tests * Update options after updating the tests * Fix documentation bug * Fix documentation issue and migrate ruby code * Fix proxy documentation issue --------- Co-authored-by: aguspe <agustin.pe94@gmail.com> Co-authored-by: Sri Harsha <12621691+harsha509@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
Description
This PR updates the upgrade to selenium 4 documentation to avoid the wrong rendering of the ruby examples and also moves the ruby examples for the before section to the options_spec file
This PR needs to be merged after #1679
Motivation and Context
Currently due to changes I introduced in #1668 the rendering of the ruby example in the upgrade selenium page is wrong:
Screenshot 2024年04月26日 at 17 57 00
This PR fixes that and migrates the ruby example on the before tab
Types of changes
Checklist