-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Nightly and Stable for JS and DotNet #1682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Description updated to latest commit (2b8535f)
- Copy walkthrough table to "Files Changed" Tab
PR Review
3, because the PR involves multiple files and configurations, including GitHub Actions and project dependencies for different environments and release types. Understanding the matrix strategy and conditional setups requires careful attention to detail.
No
Possible Bug: The use of different action versions for retry in the dotnet and js workflows (nick-invision/retry@v3.0.0 vs nick-fields/retry@v3.0.0) might be a typo or error. This inconsistency should be clarified or corrected.
Configuration Error: The NODE_AUTH_TOKEN is only set in the environment for the 'Install Requirements' step in the JS workflow. If this token is necessary for private or nightly packages, it should be included in all relevant steps or jobs that require authentication.
No
✨ Review tool usage guide:
Overview:
The review tool scans the PR code changes, and generates a PR review which includes several types of feedbacks, such as possible PR issues, security threats and relevant test in the PR. More feedbacks can be added by configuring the tool.
The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
- When commenting, to edit configurations related to the review tool (
pr_reviewersection), use the following template:
/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...
- With a configuration file, use the following template:
[pr_reviewer]
some_config1=...
some_config2=...
See the review usage page for a comprehensive guide on using this tool.
✅ Deploy Preview for selenium-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
PR Code Suggestions
✨ Improve tool usage guide:Overview:
See the improve usage page for a comprehensive guide on using this tool. |
✅ Deploy Preview for selenium-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
CI Failure Feedback
(Checks updated until commit 8ad8fcf)
Action: test_examples (macos-latest, stable)
Failed stage: Run tests [❌]
Failure summary:
The action failed due to multiple compilation errors in the .NET project. Specifically, there were
errors related to attempts to instantiate the static class DriverFinder in various test files.
Static classes in C# cannot be instantiated, and any attempt to do so will result in a compilation
error, which is what happened here across multiple test classes (FirefoxTest.cs, ChromeTest.cs, EdgeTest.cs, ServiceTest.cs).
Relevant error logs:
1: ##[group]Operating System 2: macOS ... 161: timeout_minutes: 20 162: max_attempts: 3 163: command: cd examples/dotnet/SeleniumDocs 164: dotnet test 165: 166: retry_wait_seconds: 10 167: polling_interval_seconds: 1 168: warning_on_retry: true 169: continue_on_error: false ... 191: Write your first app: https://aka.ms/dotnet-hello-world 192: Find out what's new: https://aka.ms/dotnet-whats-new 193: Explore documentation: https://aka.ms/dotnet-docs 194: Report issues and find source on GitHub: https://github.com/dotnet/core 195: Use 'dotnet --help' to see available commands or visit: https://aka.ms/dotnet-cli 196: -------------------------------------------------------------------------------------- 197: Determining projects to restore... 198: Restored /Users/runner/work/seleniumhq.github.io/seleniumhq.github.io/examples/dotnet/SeleniumDocs/SeleniumDocs.csproj (in 3.77 sec). 199: ##[error]/Users/runner/work/seleniumhq.github.io/seleniumhq.github.io/examples/dotnet/SeleniumDocs/Browsers/FirefoxTest.cs(204,20): error CS0712: Cannot create an instance of the static class 'DriverFinder' [/Users/runner/work/seleniumhq.github.io/seleniumhq.github.io/examples/dotnet/SeleniumDocs/SeleniumDocs.csproj] 200: ##[error]/Users/runner/work/seleniumhq.github.io/seleniumhq.github.io/examples/dotnet/SeleniumDocs/Browsers/ChromeTest.cs(180,20): error CS0712: Cannot create an instance of the static class 'DriverFinder' [/Users/runner/work/seleniumhq.github.io/seleniumhq.github.io/examples/dotnet/SeleniumDocs/SeleniumDocs.csproj] 201: ##[error]/Users/runner/work/seleniumhq.github.io/seleniumhq.github.io/examples/dotnet/SeleniumDocs/Browsers/EdgeTest.cs(180,20): error CS0712: Cannot create an instance of the static class 'DriverFinder' [/Users/runner/work/seleniumhq.github.io/seleniumhq.github.io/examples/dotnet/SeleniumDocs/SeleniumDocs.csproj] 202: ##[error]/Users/runner/work/seleniumhq.github.io/seleniumhq.github.io/examples/dotnet/SeleniumDocs/Drivers/ServiceTest.cs(41,20): error CS0712: Cannot create an instance of the static class 'DriverFinder' [/Users/runner/work/seleniumhq.github.io/seleniumhq.github.io/examples/dotnet/SeleniumDocs/SeleniumDocs.csproj] 203: ##[warning]Attempt 1 failed. Reason: Child_process exited with error code 1 204: Determining projects to restore... 205: All projects are up-to-date for restore. 206: ##[error]/Users/runner/work/seleniumhq.github.io/seleniumhq.github.io/examples/dotnet/SeleniumDocs/Drivers/ServiceTest.cs(41,20): error CS0712: Cannot create an instance of the static class 'DriverFinder' [/Users/runner/work/seleniumhq.github.io/seleniumhq.github.io/examples/dotnet/SeleniumDocs/SeleniumDocs.csproj] 207: ##[error]/Users/runner/work/seleniumhq.github.io/seleniumhq.github.io/examples/dotnet/SeleniumDocs/Browsers/ChromeTest.cs(180,20): error CS0712: Cannot create an instance of the static class 'DriverFinder' [/Users/runner/work/seleniumhq.github.io/seleniumhq.github.io/examples/dotnet/SeleniumDocs/SeleniumDocs.csproj] 208: ##[error]/Users/runner/work/seleniumhq.github.io/seleniumhq.github.io/examples/dotnet/SeleniumDocs/Browsers/EdgeTest.cs(180,20): error CS0712: Cannot create an instance of the static class 'DriverFinder' [/Users/runner/work/seleniumhq.github.io/seleniumhq.github.io/examples/dotnet/SeleniumDocs/SeleniumDocs.csproj] 209: ##[error]/Users/runner/work/seleniumhq.github.io/seleniumhq.github.io/examples/dotnet/SeleniumDocs/Browsers/FirefoxTest.cs(204,20): error CS0712: Cannot create an instance of the static class 'DriverFinder' [/Users/runner/work/seleniumhq.github.io/seleniumhq.github.io/examples/dotnet/SeleniumDocs/SeleniumDocs.csproj] 210: ##[warning]Attempt 2 failed. Reason: Child_process exited with error code 1 211: Determining projects to restore... 212: All projects are up-to-date for restore. 213: ##[error]/Users/runner/work/seleniumhq.github.io/seleniumhq.github.io/examples/dotnet/SeleniumDocs/Drivers/ServiceTest.cs(41,20): error CS0712: Cannot create an instance of the static class 'DriverFinder' [/Users/runner/work/seleniumhq.github.io/seleniumhq.github.io/examples/dotnet/SeleniumDocs/SeleniumDocs.csproj] 214: ##[error]/Users/runner/work/seleniumhq.github.io/seleniumhq.github.io/examples/dotnet/SeleniumDocs/Browsers/FirefoxTest.cs(204,20): error CS0712: Cannot create an instance of the static class 'DriverFinder' [/Users/runner/work/seleniumhq.github.io/seleniumhq.github.io/examples/dotnet/SeleniumDocs/SeleniumDocs.csproj] 215: ##[error]/Users/runner/work/seleniumhq.github.io/seleniumhq.github.io/examples/dotnet/SeleniumDocs/Browsers/EdgeTest.cs(180,20): error CS0712: Cannot create an instance of the static class 'DriverFinder' [/Users/runner/work/seleniumhq.github.io/seleniumhq.github.io/examples/dotnet/SeleniumDocs/SeleniumDocs.csproj] 216: ##[error]/Users/runner/work/seleniumhq.github.io/seleniumhq.github.io/examples/dotnet/SeleniumDocs/Browsers/ChromeTest.cs(180,20): error CS0712: Cannot create an instance of the static class 'DriverFinder' [/Users/runner/work/seleniumhq.github.io/seleniumhq.github.io/examples/dotnet/SeleniumDocs/SeleniumDocs.csproj] 217: ##[error]Final attempt failed. Child_process exited with error code 1
✨ CI feedback usage guide:
The CI feedback tool (/checks) automatically triggers when a PR has a failed check.
The tool analyzes the failed checks and provides several feedbacks:
- Failed stage
- Failed test name
- Failure summary
- Relevant error logs
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:
/checks "https://github.com/{repo_name}/actions/runs/{run_number}/job/{job_number}"
where {repo_name} is the name of the repository, {run_number} is the run number of the failed check, and {job_number} is the job number of the failed check.
Configuration options
enable_auto_checks_feedback- if set to true, the tool will automatically provide feedback when a check is failed. Default is true.excluded_checks_list- a list of checks to exclude from the feedback, for example: ["check1", "check2"]. Default is an empty list.enable_help_text- if set to true, the tool will provide a help message with the feedback. Default is true.persistent_comment- if set to true, the tool will overwrite a previous checks comment with the new feedback. Default is true.final_update_message- ifpersistent_commentis true and updating a previous checks message, the tool will also create a new message: "Persistent checks updated to latest commit". Default is true.
See more information about the checks tool in the docs.
Uh oh!
There was an error while loading. Please reload this page.
User description
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist
Type
enhancement, configuration changes
Description
package.nightly.jsonfor JavaScript to manage nightly dependencies separately.Changes walkthrough
dotnet-examples.yml
Update .NET GitHub Actions Workflow for Nightly and Stable Builds.github/workflows/dotnet-examples.yml
SE_RELEASEadded to specify the release typeduring test execution.
js-examples.yml
Update JavaScript GitHub Actions Workflow for Nightly and StableBuilds.github/workflows/js-examples.yml
package.jsonfor nightly builds depending on the OS.NODE_AUTH_TOKENduring npm install.SeleniumDocs.csproj
Configure .NET Project for Nightly and Stable Dependency Managementexamples/dotnet/SeleniumDocs/SeleniumDocs.csproj
stable releases.
package.nightly.json
Add Nightly package.json for JavaScript Examplesexamples/javascript/package.nightly.json
updated dependencies.