Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Update announcement-banner.html foe SeConf CFP #1676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diemol merged 1 commit into SeleniumHQ:trunk from digitalvoice-nz:patch-1
Apr 18, 2024

Conversation

@digitalvoice-nz
Copy link
Contributor

@digitalvoice-nz digitalvoice-nz commented Apr 18, 2024 •
edited by qodo-merge-pro bot
Loading

User description

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

Changed banner to promote Selenium Conf 2024 call for proposals

Motivation and Context

Selenium Conf 2024 is coming!

Types of changes

  • [- ] Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

Type

enhancement

Description

  • Updated the announcement banner on the Selenium website to promote the Call for Proposals for Selenium Conf 2024.
  • Changed the previous banner content about WebDriver BiDi to the new content focusing on the upcoming conference.
  • Updated the link to direct to the Selenium Conf 2024 proposal submission page, enhancing user redirection for potential speakers.

Changes walkthrough

Relevant files
Enhancement
announcement-banner.html
Update Announcement Banner for Selenium Conf 2024 CFP

website_and_docs/layouts/partials/announcement-banner.html

  • Updated the announcement banner content to promote Selenium Conf 2024
    Call for Proposals.
  • Changed the link to direct users to the proposal submission page for
    Selenium Conf 2024.
    • +2/-2

    ✨ PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    Copy link

    netlify bot commented Apr 18, 2024 •
    edited
    Loading

    ✅ Deploy Preview for selenium-dev ready!

    Name Link
    🔨 Latest commit 3c8329c
    🔍 Latest deploy log https://app.netlify.com/sites/selenium-dev/deploys/6620f6fd5f93bc00092c4589
    😎 Deploy Preview https://deploy-preview-1676--selenium-dev.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    Copy link

    CLAassistant commented Apr 18, 2024 •
    edited
    Loading

    CLA assistant check
    All committers have signed the CLA.

    @qodo-merge-pro qodo-merge-pro bot added the enhancement New feature or request label Apr 18, 2024
    Copy link
    Contributor

    PR Description updated to latest commit (3c8329c)

    Copy link
    Contributor

    PR Review

    ⏱️ Estimated effort to review [1-5]

    2, because the PR involves a straightforward update to a single HTML file with changes in text and hyperlink. The scope is limited and the changes are clear, making it relatively easy and quick to review.

    🧪 Relevant tests

    No

    🔍 Possible issues

    Possible Bug: The URL in the new hyperlink includes multiple query parameters for tracking purposes. Ensure that these parameters are correctly formatted and do not cause any issues with the URL functionality.

    🔒 Security concerns

    No
    ✨ Review tool usage guide:

    Overview:
    The review tool scans the PR code changes, and generates a PR review which includes several types of feedbacks, such as possible PR issues, security threats and relevant test in the PR. More feedbacks can be added by configuring the tool.

    The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.

    • When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:
    /review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...

    [pr_reviewer]
some_config1=...
some_config2=...

    See the review usage page for a comprehensive guide on using this tool.
    Copy link
    Contributor

    PR Code Suggestions

    CategorySuggestions
    Best practice
    Ensure attribute values in HTML tags use double quotes for consistency and standards compliance.

    Replace the single quotes around '_blank' with double quotes for consistency with HTML
    standards.

    website_and_docs/layouts/partials/announcement-banner.html [10] 

    -<a href="https://2024.seleniumconf.in/submit-a-proposal/?utm_medium=referral&utm_source=selenium.dev&utm_campaign=CFP-launch&utm_content=cfp-page" target='_blank' aria-pressed="true">Learn more & submit</a>
+<a href="https://2024.seleniumconf.in/submit-a-proposal/?utm_medium=referral&utm_source=selenium.dev&utm_campaign=CFP-launch&utm_content=cfp-page" target="_blank" aria-pressed="true">Learn more & submit</a>
    Use semantic HTML to improve accessibility and SEO.

    Ensure the use of semantic HTML by replacing

    with a more appropriate tag like
    or

    , since

    is typically used for headings, which may not semantically represent this content.

    website_and_docs/layouts/partials/announcement-banner.html [9-11] 

    -<h4 class="alert-heading text-center m-0">
+<div class="alert-heading text-center m-0">
 Selenium Conf 2024 Call for Proposals is now open! Submissions close 30 April.
 <a href="https://2024.seleniumconf.in/submit-a-proposal/?utm_medium=referral&utm_source=selenium.dev&utm_campaign=CFP-launch&utm_content=cfp-page" target="_blank" aria-pressed="true">Learn more & submit</a>
-</h4>
+</div>

    Security
    Enhance security and performance for external links opened in new tabs.

    Add rel="noopener noreferrer" to the anchor tag to improve security and performance when
    opening links in a new tab.

    website_and_docs/layouts/partials/announcement-banner.html [10] 

    -<a href="https://2024.seleniumconf.in/submit-a-proposal/?utm_medium=referral&utm_source=selenium.dev&utm_campaign=CFP-launch&utm_content=cfp-page" target="_blank" aria-pressed="true">Learn more & submit</a>
+<a href="https://2024.seleniumconf.in/submit-a-proposal/?utm_medium=referral&utm_source=selenium.dev&utm_campaign=CFP-launch&utm_content=cfp-page" target="_blank" rel="noopener noreferrer" aria-pressed="true">Learn more & submit</a>
    Add noopener to the rel attribute to enhance security when opening a new tab.

    Add noopener to the rel attribute of the anchor tag to prevent potential security
    vulnerabilities.

    website_and_docs/layouts/partials/announcement-banner.html [10] 

    -<a href="https://2024.seleniumconf.in/submit-a-proposal/?utm_medium=referral&utm_source=selenium.dev&utm_campaign=CFP-launch&utm_content=cfp-page" target="_blank" aria-pressed="true">Learn more & submit</a>
+<a href="https://2024.seleniumconf.in/submit-a-proposal/?utm_medium=referral&utm_source=selenium.dev&utm_campaign=CFP-launch&utm_content=cfp-page" target="_blank" rel="noopener" aria-pressed="true">Learn more & submit</a>
    Accessibility
    Improve accessibility for users with assistive technologies by adding aria-label to links.

    Consider adding aria-label to the anchor tag to improve accessibility by providing a clear
    description of the link's purpose for screen readers.

    website_and_docs/layouts/partials/announcement-banner.html [10] 

    -<a href="https://2024.seleniumconf.in/submit-a-proposal/?utm_medium=referral&utm_source=selenium.dev&utm_campaign=CFP-launch&utm_content=cfp-page" target="_blank" aria-pressed="true">Learn more & submit</a>
+<a href="https://2024.seleniumconf.in/submit-a-proposal/?utm_medium=referral&utm_source=selenium.dev&utm_campaign=CFP-launch&utm_content=cfp-page" target="_blank" aria-pressed="true" aria-label="Learn more about Selenium Conf 2024 and submit your proposal">Learn more & submit</a>
    ✨ Improve tool usage guide:

    Overview:
    The improve tool scans the PR code changes, and automatically generates suggestions for improving the PR code. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.

    • When commenting, to edit configurations related to the improve tool (pr_code_suggestions section), use the following template:
    /improve --pr_code_suggestions.some_config1=... --pr_code_suggestions.some_config2=...

    [pr_code_suggestions]
some_config1=...
some_config2=...

    See the improve usage page for a comprehensive guide on using this tool.

    Copy link
    Member

    @diemol diemol left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Thank you, @digitalvoice-nz!

    @diemol diemol merged commit fc16cf5 into SeleniumHQ:trunk Apr 18, 2024
    selenium-ci added a commit that referenced this pull request Apr 18, 2024
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @diemol diemol diemol approved these changes

    Assignees

    No one assigned

    Labels

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    AltStyle によって変換されたページ (->オリジナル) /