-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
German #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
German #166
Conversation
copied *.en.md to *.de.md files
Added German (de) and translated shortcuts
from contributing.en.md
for locating_elements
Quick Tour and Landing page
copied *.en.md to *.de.md files
for locating_elements
Co-authored-by: Diego Molina <diemol@users.noreply.github.com>
CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.
✅ boris779
✅ diemol
✅ Madh93
❌ selenium-ci
You have signed the CLA already but the status is still pending? Let us recheck it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @boris779 ,
Other docs describe this page as 'working with cookies' and in the translated page, it says 'Handling cookies'. It should be 'Arbeiten mit Cookies' i think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are right, I will change that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @boris779,
This section is removed from WebDriver and placed in support packages I think. This should be removed i think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
of course, I will remove that
documentation/de/getting_started_with_webdriver/third_party_drivers_and_plugins/index.html
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @boris779,
Thanks for the PR. At some places translated texts need to be changed when compared to other docs (These are minor) But need to remove mouse.de.md from webdriver section
Thanks,
Harsha
Translation of "Handling Cookies"
copied *.en.md to *.de.md files
for locating_elements
Co-authored-by: Diego Molina <diemol@users.noreply.github.com>
german translation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @boris779,
Thank you for this PR, but it has changes in 631 files❗️We really prefer small PRs.
Could you please fix the commit history so we only need to review the affected files for the German translation?
Hi @diemol!
I have no idea how that could happen. While rebasing a lot of conflicts are shown.
How can I fix the commit history? (Never done before)
What I learned from this commit is to immediately push every translation so that should never happen again.
copied *.en.md to *.de.md files
for locating_elements
Co-authored-by: Diego Molina <diemol@users.noreply.github.com>
Sorry I do not see a chance to fix that PR.
I will close it and try it again.
Updated german files. Due to some rebasing conflicts, it took me some time to do all the stuff.
Description
German translation of documentation
Motivation and Context
Types of changes
Checklist