-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add VirtualAuthenticator tests to Ruby examples #1536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VirtualAuthenticator tests to Ruby examples #1536
Conversation
* Adding these tests helps document how the Selenium library can be used with virtual authenticators
👷 Deploy request for selenium-dev pending review.Visit the deploys page to approve it
|
CLA assistant check
All committers have signed the CLA.
@A1exKH
A1exKH
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@tcannonfodder can you merge trunk into your branch? Or make the PR editable so we can do that for you.
Done!
Please check the linter errors.
It is easier if you let us update your branch because we are merging other PRs and yours will be out of date.
Hey there!
I’m not seeing the option to do so on my end :/, based on these docs: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork
image
OK. Why don't you skip the failed test and leave a note on it?
Thanks. I will close this one and follow up on the other one.
Description
Motivation and Context
Types of changes
Checklist