-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Update windows.en.md #1535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update windows.en.md #1535
Conversation
fixed sample code to open a new window or tab using ruby
👷 Deploy request for selenium-dev pending review.Visit the deploys page to approve it
|
CLA assistant check
All committers have signed the CLA.
Good catch, we changed the implementation of this and didn't update the documentation.
Can you update these lines in all 4 of the translation files?
(or if you are interested in being especially helpful write the code here so we can link to it in the docs? https://github.com/SeleniumHQ/seleniumhq.github.io/blob/trunk/examples/ruby/spec/interactions/windows_spec.rb)
fix documentation on how to open a new browser tab or window using ruby
@ronPy please sign the CLA. Thanks.
updated docs to use sample code
website_and_docs/content/documentation/webdriver/interactions/windows.ja.md
Outdated
Show resolved
Hide resolved
website_and_docs/content/documentation/webdriver/interactions/windows.ja.md
Outdated
Show resolved
Hide resolved
website_and_docs/content/documentation/webdriver/interactions/windows.pt-br.md
Outdated
Show resolved
Hide resolved
website_and_docs/content/documentation/webdriver/interactions/windows.pt-br.md
Outdated
Show resolved
Hide resolved
website_and_docs/content/documentation/webdriver/interactions/windows.zh-cn.md
Outdated
Show resolved
Hide resolved
website_and_docs/content/documentation/webdriver/interactions/windows.zh-cn.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for taking the extra step here!
A couple updates specific to how Hugo/Docsy need things formatted.
Also, I don't think we need to include any of the navigation things? Just the command to create the window/tab (and the assertion in the specs so when we run it in the CI we know it is working.
website_and_docs/content/documentation/webdriver/interactions/windows.en.md
Outdated
Show resolved
Hide resolved
website_and_docs/content/documentation/webdriver/interactions/windows.en.md
Outdated
Show resolved
Hide resolved
website_and_docs/content/documentation/webdriver/interactions/windows.en.md
Outdated
Show resolved
Hide resolved
website_and_docs/content/documentation/webdriver/interactions/windows.en.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @ronPy!
fixed sample code to open a new window or tab using ruby
Description
current sample code doesn't work, with this change user will be pointed to the right direction on how to open a new window or tab using ruby
Motivation and Context
I was trying to achieve this and following the sample code didn't work, after looking at other languages I figured it out, maybe some people won't do that I will think the feature is just not working in ruby
Types of changes
Checklist