Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

# feat : Add Portuguese translation in support_features file expected_conditions #1514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sombo20 wants to merge 8 commits into SeleniumHQ:trunk from Afranioalves:trunk

Conversation

@sombo20
Copy link
Contributor

@sombo20 sombo20 commented Oct 25, 2023 •
edited
Loading

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

@aosccode

Copy link

netlify bot commented Oct 25, 2023

👷 Deploy request for selenium-dev pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit ab7b5bd

@sombo20 sombo20 changed the title (削除) # feat : Add Portuguese translation in webdriver/support_features/expected_conditions (削除ここまで) (追記) # feat : Add Portuguese translation in support_features file expected_conditions (追記ここまで) Oct 25, 2023
Copy link
Member

diemol commented Oct 25, 2023

There is no need to tag people. We all get an email notification and we will review when time permits.
sombo20 reacted with heart emoji

Copy link
Contributor Author

sombo20 commented Oct 25, 2023

@diemol right!

Copy link
Contributor

For future commits, please commit one file at the time, this takes longer to review.

Copy link
Contributor Author

sombo20 commented Oct 25, 2023

@luisfcorreia I commit this file expected_conditions

Copy link

@A1exKH A1exKH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sombo20 please, resolve conflicts for this PR.

Copy link

netlify bot commented Nov 18, 2024

👷 Deploy request for selenium-dev pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 6c9842f

Copy link

@A1exKH A1exKH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

diemol commented Jun 18, 2025

This went stale, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@A1exKH A1exKH A1exKH approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /