Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

[Docs] Add test runners information for Ruby. #1477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

@flynnbops
Copy link

@flynnbops flynnbops commented Sep 14, 2023 •
edited
Loading

Description

Fixes #1476

Adding Ruby test runner instructions to the Webdriver Getting started docs.

Motivation and Context

Missing information.

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

Renders locally

Screenshot 2023年09月14日 at 12 50 10

Copy link

netlify bot commented Sep 14, 2023 •
edited
Loading

👷 Deploy request for selenium-dev pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 55755fa

Copy link

CLAassistant commented Sep 14, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@flynnbops flynnbops marked this pull request as ready for review September 14, 2023 12:50
@flynnbops flynnbops changed the title (削除) Add test runners information for Ruby. (削除ここまで) (追記) [Docs] Add test runners information for Ruby. (追記ここまで) Sep 14, 2023
Copy link
Member

@flynnbops thank you for this PR.

The recent requests to add Test Runner information to our documentation, and @pallavigitwork's request that we not have the initial example include being part of a test runner has prompted me to do #1479.

Can you give feedback on that one? If we merge it, can you help write the code we want to use in that format instead of this PR? Thanks.

Copy link
Author

flynnbops commented Sep 15, 2023 •
edited
Loading

Thanks I'll have a proper look soon.

From my initial look at the new approach it looks cleaner.

And yes happy to help out with the code and docs.

Closing this PR.
titusfortner reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[🚀 Feature]: Add instructions for Ruby in the 'Test Runners' section

AltStyle によって変換されたページ (->オリジナル) /