-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
update wait documentation #1358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for selenium-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
review comments provided my @iamalittletester!
ollie-iterators
commented
Jun 15, 2023
If there are more areas that need their static code to be changed to references to the examples directory, I think there should be an issue added about the areas that need this to happen.
@ollie-iterators if we merge the PR I just linked we can tag the static code with {{ badge-examples }} to indicate that it needs to be moved over.
I'm planning to record some screen captures next week walking through each step of contributing to the documentation to better document what we're asking people to do to help.
ollie-iterators
commented
Jun 16, 2023
@ollie-iterators if we merge the PR I just linked we can tag the static code with
{{ badge-examples }}to indicate that it needs to be moved over.I'm planning to record some screen captures next week walking through each step of contributing to the documentation to better document what we're asking people to do to help.
Great.
Oof, this totally fell off my radar; I was going to do a quick update to get these changes out there, and of course... the structure is still confusing...
2baefb4 to
357f13b
Compare
357f13b to
279fc5a
Compare
Ok, removed a bunch of repetitive things in explicit waits section, hopefully easier to read now.
website_and_docs/content/documentation/webdriver/support_features/expected_conditions.en.md
Outdated
Show resolved
Hide resolved
odd there were a couple other places with double parens that seemed to work. Oh, I bet it was the combination double parens and the anchor reference at the end of the link...
Fixed all of them anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @titusfortner 🎉
* update wait documentation * updates based on feedback and removing unnecessary explanations * fix all double-parentheses links d1af4fe
Description
FluentWaitclass)Motivation and Context