Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Adding arguments to Java and C# #1300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diemol merged 6 commits into trunk from adding-argument-chrome
Jan 30, 2023
Merged

Adding arguments to Java and C# #1300

diemol merged 6 commits into trunk from adding-argument-chrome
Jan 30, 2023

Conversation

@diemol
Copy link
Member

@diemol diemol commented Jan 30, 2023

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

oscarsun72 reacted with heart emoji
Copy link

netlify bot commented Jan 30, 2023
edited
Loading

Deploy Preview for jovial-austin-42fe02 failed.

Name Link
🔨 Latest commit f06cbfb
🔍 Latest deploy log https://app.netlify.com/sites/jovial-austin-42fe02/deploys/63d83dae63df2e000939ee41
oscarsun72 reacted with heart emoji

Copy link
Member

  1. Should we add this to Edge & Firefox as well?
  2. Should we add it to the actual documentation?

Copy link
Member Author

diemol commented Jan 30, 2023

Yes to both.
Just trying to do one commit at a time.

titusfortner reacted with thumbs up emoji oscarsun72 reacted with heart emoji

@diemol diemol merged commit 500c8c7 into trunk Jan 30, 2023
@diemol diemol deleted the adding-argument-chrome branch January 30, 2023 22:10
{
var options = new FirefoxOptions();
options.AddArgument("-headless");
options.AddArgument("--headless");
Copy link
Member

@titusfortner titusfortner Jan 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Firefox documentation has only one dash

oscarsun72 reacted with heart emoji
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

selenium-ci added a commit that referenced this pull request Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@titusfortner titusfortner titusfortner left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /