-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Customize a node docs enhancement #1223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
diemol
merged 4 commits into
SeleniumHQ:trunk
from
krmahadevan:customized_node_doc_changes
Nov 10, 2022
Merged
Customize a node docs enhancement #1223
diemol
merged 4 commits into
SeleniumHQ:trunk
from
krmahadevan:customized_node_doc_changes
Nov 10, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for jovial-austin-42fe02 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@krmahadevan
krmahadevan
force-pushed
the
customized_node_doc_changes
branch
from
November 10, 2022 05:28
41a5abf to
d74be79
Compare
diemol
diemol
requested changes
Nov 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments, thank you.
website_and_docs/content/documentation/grid/advanced_features/customize_node.en.md
Outdated
Show resolved
Hide resolved
* Added details on how node types * Made some formatting changes to the docs.
@krmahadevan
krmahadevan
force-pushed
the
customized_node_doc_changes
branch
from
November 10, 2022 11:15
91fd7dc to
244d633
Compare
diemol
diemol
approved these changes
Nov 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @krmahadevan!
selenium-ci
added a commit
that referenced
this pull request
Nov 10, 2022
* Customize a node docs enhancement * Added details on how node types * Made some formatting changes to the docs. * Removing the aliases * Fixing the dependencies information * Removed alias sections [deploy site] f9f1684
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
Enhanced the docs for customising a node and added details on how to use a regular jar via
--extargument.Also added details on Node implementation types and their relevance
Description
Motivation and Context
Types of changes
Checklist