-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
docs(zh-cn): update elements/information #1214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CLA assistant check
All committers have signed the CLA.
website_and_docs/content/documentation/webdriver/elements/information.zh-cn.md
Show resolved
Hide resolved
✅ Deploy Preview for jovial-austin-42fe02 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's great to add original author un-synced parts here (isEnabled, Size and Position, Text Content...), actually I really didn't realize the new content in English page.
But, why you re-translated all page? seems no big changed in existing content, but you change here and there.
And meanwhile, please follow contribution rule for new content .
https://www.selenium.dev/documentation/about/contributing/#step-4-commit
website_and_docs/content/documentation/webdriver/elements/information.zh-cn.md
Outdated
Show resolved
Hide resolved
website_and_docs/content/documentation/webdriver/elements/information.zh-cn.md
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost content is readable and updated.
But seems you didn't mention the content which you overwrite, please take care of attribute and property part, you replace with highlight part with your owned thought...
I'm fine with other parts if Jason could update the last part.
website_and_docs/content/documentation/webdriver/elements/information.zh-cn.md
Outdated
Show resolved
Hide resolved
website_and_docs/content/documentation/webdriver/elements/information.zh-cn.md
Outdated
Show resolved
Hide resolved
website_and_docs/content/documentation/webdriver/elements/information.zh-cn.md
Outdated
Show resolved
Hide resolved
...rmation.zh-cn.md Co-authored-by: Jason Ren <40999116+jasonren0403@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks~
* docs(zh-cn): update elements/information * Add back "Is Enabled" part * try wrap all line into 72 columns * Update website_and_docs/content/documentation/webdriver/elements/information.zh-cn.md * Update website_and_docs/content/documentation/webdriver/elements/information.zh-cn.md Co-authored-by: Jason Ren <40999116+jasonren0403@users.noreply.github.com> Co-authored-by: ian zhang <ian.zhangzhe@gmail.com> Co-authored-by: Diego Molina <diemol@users.noreply.github.com> [deploy site] 9ba7b24
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
Description
Update Element information document and do some little improvement
Motivation and Context
help zh-cn users understand better
Types of changes
Checklist