-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Provide Mocha install instructions to run first JS script #1185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CLA assistant check
All committers have signed the CLA.
✅ Deploy Preview for jovial-austin-42fe02 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First, thanks for this PR.
The goal of the "first script" page is to try to demonstrate the minimum necessary for executing Selenium code. I think the right answer here is to create a new page in Getting Started Section for "Scaling Selenium" or "Test Runners" or something. Let's discuss in #documentation channel and see where we want to take this.
What was the conclusion of the discussion?
I have created a section for Test Runners in here https://www.selenium.dev/documentation/webdriver/getting_started/first_script/#test-runners
But needs a decision on this too!
That section probably makes sense, but I would leave it in a different page and link it from the First Script page, as it is now, it can confuse more than clarify.
I think what we want to do is to create a separate test_runners.md docs file where we discuss why you would use a test runner, list the various options in each language, and then show code for the ones we're using in examples/
Thank you for the PR @dublinsubway !
It appears that the documentation has already been updated with instructions on how to run tests using Mocha.
Closing this PR considering it's already resolved.
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
Description
Add a line explaining the way to run their script as it might not be clear for beginners. Closes #1160.
Motivation and Context
Providing people with a bit more detailed information about the way they can run their first test script locally.
Types of changes
Checklist