Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

add new blog post about BELLATRIX test automation framework #1153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diemol merged 4 commits into SeleniumHQ:trunk from AutomateThePlanet:trunk
Nov 16, 2022

Conversation

@angelovstanton
Copy link
Contributor

@angelovstanton angelovstanton commented Aug 30, 2022 •
edited
Loading

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

I added a blog post regarding BELLATRIX test automation framework which we discussed with Diego Molina to be added as one of the frameworks from the Selenium Ecosystem

Motivation and Context

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

Copy link

CLAassistant commented Aug 30, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Copy link

netlify bot commented Aug 30, 2022 •
edited
Loading

✅ Deploy Preview for jovial-austin-42fe02 ready!

Name Link
🔨 Latest commit 97aee03
🔍 Latest deploy log https://app.netlify.com/sites/jovial-austin-42fe02/deploys/6373bc854e7a5c000861d7b7
😎 Deploy Preview https://deploy-preview-1153--jovial-austin-42fe02.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

diemol commented Nov 1, 2022

Apologies for the delay reviewing this, I will have a look tomorrow and merge it if everything is OK.

Copy link
Contributor Author

Apologies for the delay reviewing this, I will have a look tomorrow and merge it if everything is OK.

No problem! I completely understand your busy schedule. As we discussed in Slack when we publish the blog post it will be great also to link the framework on the Ecosystem page where other frameworks are so that people can find it faster. Lastly when we talked we discussed all details. If there is anything related to the PR. Let's quickly resolve it in Slack, I will be online the whole working day! Thank you!

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 @angelovstanton, I left some comments and a remark at the end. Feel free to reach out in Slack so we can move forward.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a couple of suggestions and then we can merge tomorrow.

angelovstanton and others added 2 commits November 15, 2022 18:21 
...ramework/index.md
apply Diego's suggestion
Co-authored-by: Diego Molina <diemol@users.noreply.github.com>
...ramework/index.md
apply Diego's suggestion
Co-authored-by: Diego Molina <diemol@users.noreply.github.com>
Copy link
Contributor Author

I committed directly from GitHub the two suggestions you made so I think we are good to go. Probably before publishing you need just to add the framework link to the Ecosystem page ( https://www.selenium.dev/ecosystem/) as we discussed before

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @angelovstanton!

@diemol diemol merged commit 149a62d into SeleniumHQ:trunk Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diemol diemol diemol approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /