Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Add: Added JavaScript sample code for remote_webdriver_client #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diemol merged 25 commits into SeleniumHQ:master from hiroksarker:master
Dec 7, 2019
Merged

Add: Added JavaScript sample code for remote_webdriver_client #114

diemol merged 25 commits into SeleniumHQ:master from hiroksarker:master
Dec 7, 2019

Conversation

@hiroksarker
Copy link
Contributor

@hiroksarker hiroksarker commented Dec 4, 2019 •
edited
Loading

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Change to the site (I am attaching a screenshot showing the before and after)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

hiroksarker and others added 16 commits October 28, 2019 21:33 
Completing the translation completed C#
Completing the translation browser_navigation
Completing the translation for #53 
Completing the translation for #52
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments, thanks for this PR @hiroksarker!

(async function helloSelenium() {
let driver = new Builder()
//Browser Window Size Set
.setChromeOptions(new chrome.Options().windowSize({ width, height }))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am really sorry, perhaps I have not been clear 😢
The other examples are living through the idea of: suppose you wanted to run Chrome on Windows XP using Chrome version 67...
So, if we see the Java example, it is using ChromeOptions to set those values. It would be nice to see the JavaScript example do the same thing, to keep uniformity. We do not need to set a window size or headless option, it is to make all the examples in different languages do the same.
Does it make sense?

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @hiroksarker!

hiroksarker reacted with heart emoji
@diemol diemol merged commit d8cd240 into SeleniumHQ:master Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harsha509 harsha509 harsha509 left review comments

@diemol diemol diemol approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /