Update remote_webdriver_client.en.md #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

jt-pham wants to merge 2 commits into SeleniumHQ:master from jt-pham:patch-1

Closed

Update remote_webdriver_client.en.md #111

jt-pham wants to merge 2 commits into SeleniumHQ:master from jt-pham:patch-1

Conversation

@jt-pham

Copy link

@jt-pham jt-pham commented Dec 3, 2019 •

edited

Loading

I added some Remote WebDriver and DesiredCapabilities examples in Python

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

Change to the site (I am attaching a screenshot showing the before and after)
Code example added (and I also added the example to all translated languages)
Improved translation
Added new translation (and I also added a notice to each document missing translation)

Checklist

I have read the contributing document.
I have used hugo to render the site/docs locally and I am sure it works.

@jt-pham


 Update remote_webdriver_client.en.md

d9f3175

I added some Remote WebDriver and DesiredCapabilities examples in Python

@harsha509

Copy link

Member

harsha509 commented Dec 4, 2019

Hi @jt-pham,

Can you please update the sample code in all the translated pages too.

Thanks!

diemol

diemol requested changes

Dec 5, 2019

View reviewed changes

Copy link

Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple of comments, additionally, please add these code examples to the other translated files.

docs_source_files/content/remote_webdriver/remote_webdriver_client.en.md

# We don't have a Python code sample yet - Help us out and raise a PR

from selenium import webdriver

from selenium.webdriver.common.desired_capabilities import DesiredCapabilities

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not use DesiredCapabilities, you can follow the other examples and use FirefoxOptions

docs_source_files/content/remote_webdriver/remote_webdriver_client.en.md

# We don't have a Python code sample yet - Help us out and raise a PR

# https://github.com/SeleniumHQ/selenium/wiki/DesiredCapabilities

from selenium import webdriver

from selenium.webdriver.common.desired_capabilities import DesiredCapabilities

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above.

@diemol


 Merge branch 'master' into patch-1

ddcbca2

@diemol

Copy link

Member

diemol commented Dec 22, 2019

For all watchers, this PR has gone stale, if anyone wants to submit it again, feel free to do so and please give credit to the original author.

@harsha509

Copy link

Member

harsha509 commented Dec 26, 2019

For all watchers, this PR has gone stale, if anyone wants to submit it again, feel free to do so and please give credit to the original author.

hi @jt-pham ,

Thanks for providing the PR.

As the PR gone stale now, I've updated the sample code in PR #153

diemol pushed a commit that referenced this pull request

Dec 26, 2019

@harsha509 @manoj9788 @diemol


 Modify: PR for stale pr #111 ( #153 ) [deploy site]

b59a3a2

* Modify: Removed unneccessary awaits for find element
Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>
* Add: Added ruby sample code for mouse actionsin support package
Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>
* Modify: Revamping the WebElement usage document
Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>
* Add: Adding findElements section to web_element document
Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>
* Modify: Update to stale PR #111
Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>
* Modify: Removed desired capabilities and used FirefoxOptions in code sample
Signed-off-by: Sri Harsha <sri_harsha509@hotmail.com>
Co-authored-by: Manoj Kumar <manoj9788@gmail.com>

@diemol

Copy link

Member

CLAassistant commented Jul 1, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ diemol
❌ jt-pham
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

Labels

None yet

4 participants

@jt-pham @harsha509 @diemol @CLAassistant

Uh oh!

Update remote_webdriver_client.en.md #111

Update remote_webdriver_client.en.md #111

Uh oh!

Conversation

@jt-pham jt-pham commented Dec 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Motivation and Context

Types of changes

Checklist

Uh oh!

harsha509 commented Dec 4, 2019

Uh oh!

@diemol diemol left a comment

Choose a reason for hiding this comment

Uh oh!

@diemol diemol Dec 5, 2019

Choose a reason for hiding this comment

Uh oh!

@diemol diemol Dec 5, 2019

Choose a reason for hiding this comment

Uh oh!

diemol commented Dec 22, 2019

Uh oh!

harsha509 commented Dec 26, 2019

Uh oh!

diemol commented Dec 26, 2019

Uh oh!

CLAassistant commented Jul 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

@jt-pham jt-pham commented Dec 3, 2019 •

edited

Loading