-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
1st chunk for German translation #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
copied *.en.md to *.de.md files
Added German (de) and translated shortcuts
CLA assistant check
All committers have signed the CLA.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hii @boris779, thank you for this PR!
I left a few comments, but in general, it seems that the fork where this PR is based is not up to date, and therefore the new files for the file structure are having old content in English.
What if we take a step back, and instead of sending a PR with all files, we have smaller PRs adding the chunks little by little. Yes, I know that everything won't work until we have all files, but the review will be easier and the content up to date. It does not matter that the content comes in English, but at least it will be up to date.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is out of date, for example, we do not have this step anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this file? Did it get committed by mistake?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry. was a script to create all the de files, I removed it already
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also out of date. I believe the fork was not updated with the recent changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated my PR, see comment below.
Hi @diemol! Sorry my fault, it took me too long to push this Pull request. So I thought this is a small chunk because only headlines and navigation are translated.
So what do you think is the best way without losing my changes so far? I don't want to start over. Minutes ago I merged everything from upstream/master into my german branch.
Now I have to compare all the *.de.md files with the en.md files right?
So before this happens again, I updated all german files by manual comparison via diff in my IDE.
Hopefully, this first (big) chunk can be verified. Further translations will be of course in small chunks (page or topics).
@boris779 have you seen that the build is failing?
Sorry missed that.
for locating_elements
now also updated german files from english source.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @boris779!
I added all the necessary files and settings for German translation.
Further all headlines/menu entries are now in German.
I will translate chapter by chapter