Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Wheel examples #1010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
titusfortner wants to merge 2 commits into trunk from wheel_examples
Closed

Wheel examples #1010

titusfortner wants to merge 2 commits into trunk from wheel_examples

Conversation

@titusfortner
Copy link
Member

@titusfortner titusfortner commented May 16, 2022 •
edited
Loading

This is Draft because:

This PR is to show off demo code for what scrolling implementation looks like with the above PR

Also, probably should figure out if we like the badges and do them the right way with shortcodes and such if we like them. @diemol what do you think of the "badges" in this PR?

Copy link
Member Author

titusfortner commented May 16, 2022 •
edited
Loading

Oh, also, the JavaScript & the Kotlin aren't implemented for this because I wasn't sure what those needed to look like.

Copy link
Member Author

Do I need to move this out of draft to get it to deploy a preview?

@titusfortner titusfortner marked this pull request as ready for review May 16, 2022 00:39
Copy link

netlify bot commented May 16, 2022

✅ Deploy Preview for jovial-austin-42fe02 ready!

Name Link
🔨 Latest commit 73d3614
🔍 Latest deploy log https://app.netlify.com/sites/jovial-austin-42fe02/deploys/62819c5c2d47a80009174262
😎 Deploy Preview https://deploy-preview-1010--jovial-austin-42fe02.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@titusfortner titusfortner marked this pull request as draft May 16, 2022 00:57
+ "return f<window.pageYOffset+window.innerHeight&&t<window.pageXOffset+window.innerWidth&&f+n>\n"
+ "window.pageYOffset&&t+o>window.pageXOffset";

return (boolean) ((JavascriptExecutor) driver).executeScript(script, element);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

executeScript will return Boolean as Object, seems no need to convert as boolean?

Copy link
Member

diemol commented May 17, 2022

I like the badges idea, but there is no need to implement this on our own. Docsy uses Bootstrap, so you can use their Badges (https://getbootstrap.com/docs/4.6/components/badge/) and combine it with a Tooltip (https://getbootstrap.com/docs/4.6/components/tooltips/).
That could be embedded in a shortcode, definitely.

Copy link
Member Author

Getting rolled into #1031

@diemol diemol deleted the wheel_examples branch June 14, 2022 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alaahong alaahong alaahong left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /