-
Couldn't load subscription status.
- Fork 90
Add save/load functionality #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I was interested in saving my consoles, then loading them later. I got tired of copy and paste to/from files.
I was interested in saving my consoles, then loading them later. I got tired of copy and paste to/from files.
Added Save and Load functions
Added Save and Load functions
I copied the reset and created load/save.
Revert "Added Save and Load functions"
Sorry - I was travelling while you guys were talking about this. I removed the local storage requirement and gave credit to the original author. I tested and it works on Chrome and Firefox. Both browsers use the same codepath. I also tested Safari and note that the console doesn't work (the top panels don't show up. I doubt that's related to my change, but thought I would mention it.)
Will give it a try tomorrow
Justed tested the current version. Here is a Screenshot of how the changes look like ATM:
Feature wise:
- atm occurs a js syntax error, please fix that
SyntaxError: missing ) after argument list php-console.js:201:9
TypeError: $.console is not a function
- after fixing this error the feature itself works for me in FF41 & Chrome44
UI wise:
- the new save/load feature should be more separated from the current "reset" feature
- nit: maybe it should be named import/export instead of save/load?
- After running the script the UI gets even more crowded with the memory informatioin, see
console-export-run - When clicking "load" and the editor already contains source-code it would be good if we could add a confirm dialog before overwriting the current sources
general discussion: maybe it would make sense to export/import the file into Gists instead of local files?
Summary: the feature itself is nice, but the UI needs some polish before this can be merged.
Thanks for your work so far.
@lowrykun any updates on this ?
Sorry for the delay...