-
-
Notifications
You must be signed in to change notification settings - Fork 377
Allow to specify type on MatIconButton. Fixes #315 #325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Material icon button changes - set type in Material autocomplete Thanks!
ad9a45d to
402fb2a
Compare
Congratulations 🎉. DeepCode analyzed your code in 0.325 seconds and we found no issues. Enjoy a moment of no bugs ☀️.
👉 View analysis in DeepCode’s Dashboard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be good to set the default to "button" ??
public string Type { get; set; } = "button";
src/MatBlazor/Components/MatAutocompleteList/MatAutocompleteList.razor
Outdated
Show resolved
Hide resolved
@peterblazejewicz Thanks for contributing. Sorry it has taken a long time to get to your PR. Please review my notes and if you wish to edit your PR then I will merge into the develop branch.
Also I recommend you update the DemoIconButton to show examples of use of the new functionality: https://github.com/SamProf/MatBlazor/blob/develop/src/MatBlazor.Demo/Demo/DemoMatIconButton.razor
No need to commit this file, it will be recompiled at build
@enkodellc no worries, times we are living in :) I'll review the current library details, then update this PR (or just close as not relevant anymore). Anyway, I'll post here. Thanks!
@peterblazejewicz ,
There are conflicts
Thanks!