-
Notifications
You must be signed in to change notification settings - Fork 26
Add guide for serial flashing #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add guide for serial flashing #47
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, apart from those two smaller issues.
guides/flashing.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling error in here "There are differennt interfaces"
A user does not have to "make sure to set the FLASHING_TOOL variable". This variable only applies when you want to use the non default stm32flash tool. So you could actually make this whole text simpler by removing that sentence and...
guides/flashing.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... remove this header and explain briefly how to use stm32flash with the STM32-base project:
"If you want to use stm32flash, set the FLASHING_TOOL variable in your makefile with the value stm32flash. Make sure to also set the FLASHING_SERIAL_PORT variable to the name of the serial port you want to use."
003b011 to
eef8190
Compare
Thanks for also updating the docs
Added section 'Flashing tool' indicating how to select flashing tool.
Added section "Serial port" instructing to set FLASHING_SERIAL_PORT variable in case stm32flash is used.