-
Couldn't load subscription status.
- Fork 26
Make the primary text colour easier to read #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the primary text is coloured in relatively light gray. This commit changes it to be substantially darker and, hopefully, easier to read.
Another option would be to make bolds and headers #111111 and the primary either #222222 or #333333. The latter would give a little bit more contrast on bold text.
Here’s how it should look like after acb08d4:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the primary text is coloured in relatively light gray. This PR changes it to be substantially darker and, hopefully, easier to read.
The following picture presents three text colour variants:
#727272(current),rgba(0, 0, 0, 0.87)and#000000. This PR proposes#111111, which is somewhere between the latter ones.colours