-
Couldn't load subscription status.
- Fork 179
Improved performances #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Perfect! Thanks! I'll merge it later today.
You don't happen to have written a little benchmark that I can add to the test suite in order to prevent regressions?
Alright, it's merged. It will be released along with the refactoring/extension of the InclusionService which I'm currently working on. My changes may have an impact on your performance optimizations, as I'm planning to move the different inclusion mechanisms into separate strategies. I'll try to factor your optimizations into the rewrite as good as I can, but please let me know if you observe any decrease in performance.
Thanks again for your help!
Nice !
I also created a new pull request concerning the Collections.java classes
to improve performances while calling the filteredCopyOf method.
Tell me what do you think of it.
2014年10月27日 23:26 GMT+01:00 Daniel Bechler notifications@github.com:
—
Reply to this email directly or view it on GitHub
#113 (comment).
I will work on writing a benchmark for the previous changes
(InclusionService)
2014年10月28日 9:03 GMT+01:00 Frédéric Toublanc frederic.toublanc@oniryx.be:
Nice !
I also created a new pull request concerning the Collections.java classes
to improve performances while calling the filteredCopyOf method.
Tell me what do you think of it.2014年10月27日 23:26 GMT+01:00 Daniel Bechler notifications@github.com:
—
Reply to this email directly or view it on GitHub
#113 (comment).
I have written a benchmark but i'm using a library called "dummyCreator" to
inject randomly data in my objects.
de.dev-eth0.dummycreator
dummy-creator
1.2
test
How can i send you the test classes and java models ?
2014年10月28日 9:04 GMT+01:00 Frédéric Toublanc frederic.toublanc@oniryx.be:
I will work on writing a benchmark for the previous changes
(InclusionService)2014年10月28日 9:03 GMT+01:00 Frédéric Toublanc frederic.toublanc@oniryx.be:
Nice !
I also created a new pull request concerning the Collections.java classes
to improve performances while calling the filteredCopyOf method.
Tell me what do you think of it.2014年10月27日 23:26 GMT+01:00 Daniel Bechler notifications@github.com:
—
Reply to this email directly or view it on GitHub
#113 (comment).
Cool! Can you just put it in a public Github repository? If you don't want to do that, maybe via Dropbox Link?
On 28.10.2014, at 13:49, Deipher notifications@github.com wrote:
I have written a benchmark but i'm using a library called "dummyCreator" to
inject randomly data in my objects.
de.dev-eth0.dummycreator
dummy-creator
1.2
test
How can i send you the test classes and java models ?
2014年10月28日 9:04 GMT+01:00 Frédéric Toublanc frederic.toublanc@oniryx.be:
I will work on writing a benchmark for the previous changes
(InclusionService)2014年10月28日 9:03 GMT+01:00 Frédéric Toublanc frederic.toublanc@oniryx.be:
Nice !
I also created a new pull request concerning the Collections.java classes
to improve performances while calling the filteredCopyOf method.
Tell me what do you think of it.2014年10月27日 23:26 GMT+01:00 Daniel Bechler notifications@github.com:
—
Reply to this email directly or view it on GitHub
#113 (comment).—
Reply to this email directly or view it on GitHub.
I can't push anything from where i am (security of the company) so here is
the archive of the project.
2014年10月28日 15:07 GMT+01:00 Daniel Bechler notifications@github.com:
Cool! Can you just put it in a public Github repository? If you don't want
to do that, maybe via Dropbox Link?On 28.10.2014, at 13:49, Deipher notifications@github.com wrote:
I have written a benchmark but i'm using a library called "dummyCreator"
to
inject randomly data in my objects.
de.dev-eth0.dummycreator
dummy-creator
1.2
test
How can i send you the test classes and java models ?
2014年10月28日 9:04 GMT+01:00 Frédéric Toublanc frederic.toublanc@oniryx.be:
I will work on writing a benchmark for the previous changes
(InclusionService)2014年10月28日 9:03 GMT+01:00 Frédéric Toublanc <
frederic.toublanc@oniryx.be>:Nice !
I also created a new pull request concerning the Collections.java
classes
to improve performances while calling the filteredCopyOf method.
Tell me what do you think of it.2014年10月27日 23:26 GMT+01:00 Daniel Bechler notifications@github.com:
—
Reply to this email directly or view it on GitHub
<
https://github.com/SQiShER/java-object-diff/pull/113#event-184380590>.—
Reply to this email directly or view it on GitHub.—
Reply to this email directly or view it on GitHub
#113 (comment)
.
No description provided.