Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Improved performance of InclusionService #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Deipher wants to merge 4 commits into SQiShER:master from Deipher:master
Closed

Improved performance of InclusionService #111

Deipher wants to merge 4 commits into SQiShER:master from Deipher:master

Conversation

@Deipher
Copy link
Contributor

@Deipher Deipher commented Oct 27, 2014

Exclusions and inclusions are only checked if they have been set.

Exclusions and inclusions are only checked if they have been set.
Copy link
Owner

SQiShER commented Oct 27, 2014

Cool, thanks! I'd be happy to merge it into the master.

Unfortunately your code formatter was a little bit too aggressive, so that Git now thinks that pretty much the entire file has changed. That makes it hard to see what you actually changed. Since I'm currently also working on the InclusionService on a different branch, that would make it pretty hard to merge it back into the master without breaking your changes.

Could you please update your pull request, so that the original code style (line breaks, etc) and ordering remains intact and the git/github diff better reflects your changes?

Copy link
Contributor Author

Deipher commented Oct 27, 2014

Sorry for that. I just pasted the modified code from Eclipse with our custom formater.
I updated the file directly under Github i hope it's now better.

Just a suggestion : But using HashSet.removeAll has better performances than ArrayList.removeAll()
@Deipher Deipher changed the title (削除) Update InclusionService.java (削除ここまで) (追記) Improved performance of InclusionService (追記ここまで) Oct 27, 2014
Copy link
Owner

SQiShER commented Oct 27, 2014

Hmm, not quite. We need to get rid of the initial commit. Either you squash your commits into one or simply open a new pull request with the final state. Thanks!

Copy link
Contributor Author

Deipher commented Nov 5, 2014

Hello Daniel,

In order to plan our deliveries, do you have a due date for the release of
the version 0.91 of your library ? :)

Thx in advance.

Best regards.

2014年10月27日 16:04 GMT+01:00 Daniel Bechler notifications@github.com:

Hmm, not quite. We need to get rid of the initial commit. Either you
squash your commits into one or simply open a new pull request with the
final state. Thanks!


Reply to this email directly or view it on GitHub
#111 (comment)
.

Copy link
Owner

SQiShER commented Nov 5, 2014

I'd like to write some more tests for the new features, but I think I can release the new version tonight.

Copy link
Contributor Author

Deipher commented Nov 5, 2014

Ok :) Take your time, we just wanted to have an idea of the release date :)

2014年11月05日 13:34 GMT+01:00 Daniel Bechler notifications@github.com:

I'd like to write some more tests for the new features, but I think I can
release the new version tonight.


Reply to this email directly or view it on GitHub
#111 (comment)
.

Copy link
Owner

SQiShER commented Nov 5, 2014

In that case I think, I'll take my time and do it over the weekend. 😉

Copy link
Contributor Author

Deipher commented Nov 6, 2014

Yes :)

2014年11月05日 23:47 GMT+01:00 Daniel Bechler notifications@github.com:

In that case I think, I'll take my time and do it over the weekend. [image:
😉]


Reply to this email directly or view it on GitHub
#111 (comment)
.

Copy link
Contributor Author

Deipher commented Nov 13, 2014

Hello there,

I was that the version 0.91 is out but i can't find it under Maven
Repository :
http://mvnrepository.com/artifact/de.danielbechler/java-object-diff

Is it normal ?

Best regards.

2014年11月06日 9:41 GMT+01:00 Frédéric Toublanc frederic.toublanc@oniryx.be:

Yes :)

2014年11月05日 23:47 GMT+01:00 Daniel Bechler notifications@github.com:

In that case I think, I'll take my time and do it over the weekend. [image:
😉]


Reply to this email directly or view it on GitHub
#111 (comment)
.

Copy link
Owner

SQiShER commented Nov 13, 2014

Hmm, strange. I never actively did anything to make it available at mvnrepository.com. All I normally do is to sync it to Maven Central. And it looks like that worked. I could imagine, that mvnrepository.com simply crawls the central repository and didn't do it since the release 4 days ago.

Copy link
Contributor Author

Deipher commented Nov 14, 2014

Maybe we should wait a little bit :)

2014年11月13日 17:41 GMT+01:00 Daniel Bechler notifications@github.com:

Hmm, strange. I never actively did anything to make it available at
mvnrepository.com. All I normally do is to sync it to Maven Central. And
it looks like that worked
http://search.maven.org/#search%7Cga%7C1%7Cjava-object-diff. I could
imagine, that mvnrepository.com simply crawls the central repository and
didn't do it since the release 4 days ago.


Reply to this email directly or view it on GitHub
#111 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /