-
Notifications
You must be signed in to change notification settings - Fork 65
feat: esm support on Odata #6061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...25-esm-support-oData
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[q] Why do we need this?
test-packages/test-services-odata-v2/generate-odata-services.ts
Outdated
Show resolved
Hide resolved
...oud-sdk-js into I753325-esm-support-oData
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[q] Why did we change this? I now see an additional import statement import { RequestBuilder } from '@sap-cloud-sdk/odata-v4'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generator-common package is shared between odata and openapi generators. Have we check if this affects openapi generator?
packages/generator/src/generator.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't get why this was moved here?
packages/generator/src/imports.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't get the point of this function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great that you added tests for this. I would restructure them to test for default (which should be commonjs) or esm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[pp] If we only care about whether esm extension was generated, then I will only test for moduleIdentifier, instead of the whole object
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[q] Why did we delete this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it will make sense to create a separate type and reuse it, instead of typing it like this everywhere
Co-authored-by: Deeksha Sinha <88374536+deekshas8@users.noreply.github.com>
Co-authored-by: Deeksha Sinha <88374536+deekshas8@users.noreply.github.com>
Co-authored-by: Deeksha Sinha <88374536+deekshas8@users.noreply.github.com>
No description provided.