Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

introduce reduce with inout accumulator parameter #2611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kjaklinovic wants to merge 1 commit into ReactiveX:main
base: main
Choose a base branch
Loading
from kjaklinovic:reduce-into

Conversation

@kjaklinovic
Copy link

@kjaklinovic kjaklinovic commented Jul 13, 2024

The scan function has a variant in which it takes an input parameter as the first accumulator argument. I find that function more convenient since it requires a bit less code for the accumulator. I noticed that the same is not true for reduce, so I decided to introduce this behavior. I pretty much followed the same code style as scan has. I did the same for tests too, for every ~second existing test for reduce I introduced the new variant of the operator.

ZvonimirMedak and jcular reacted with thumbs up emoji
Copy link
Author

Hi @freak4pc , are there any further actions I need do perform for this one ? I can't check the logs of the failing checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /