-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Relays+Infallible #2430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relays+Infallible #2430
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets get some tests on this and we can merge it in.
Thanks!
RxRelay/Relays+Infallible.swift
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely needs some test coverage :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(basically just something that compares the results of the relay to the infallible is "good enough" here).
@mashe got the time to take this to the finishing line? 🙏
rtharston
commented
Aug 8, 2022
This should just replace the relay specific parts of #2401.
Basically, just replace asInfallible(onErrorFallbackTo: .empty()) in the methods added in that PR with Infallible(self.asObservable())
It already has test cases in Infallible+Tests.swift 🤔
This reverts commit 3a257bd.
Thank you, everyone for keeping eye on the PR.
@freak4pc, I have followed @rtharston suggestion, so I reverted initial commit and updated existing .asInfallible() functions for Relays. I believe additional tests are not required, since @TTOzzi noted that those exist already.
rtharston
commented
Dec 16, 2022
@freak4pc, any update on this?
1198683 to
5949cbd
Compare
original issue