Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

V6 - [WIP] #1179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
danielbarion wants to merge 45 commits into master
base: master
Choose a base branch
Loading
from v6
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
a91941c
changed classnames module with clsx
NemeZZiZZ Jul 24, 2023
2e594c7
chore: rebase from master and fix className import
danielbarion Mar 14, 2024
a83f9fd
chore: remove deprecated removeStyle util
danielbarion Mar 15, 2024
aa2c71c
chore: remove ToolTipContent and deprecated html prop
danielbarion Mar 15, 2024
cb2b8a7
chore: add tests into the chain of build command
danielbarion Mar 15, 2024
b1da496
refactor: css time to ms regex
gabrieljablonski Mar 15, 2024
59c9d07
chore: remove deprecated tooltip provider
gabrieljablonski Mar 16, 2024
5cabb44
chore: remove deprecated `anchorById` and refactor `anchorsBySelect`
gabrieljablonski Mar 16, 2024
97bbbbd
refactor: added/removed nodes effect
gabrieljablonski Mar 16, 2024
05a6c5e
chore: remove deprecated events props and `ChildrenType` -> `ReactNode`
gabrieljablonski Mar 16, 2024
db420de
chore: add hook rules to eslint and refactor relevant code
gabrieljablonski Mar 16, 2024
2a6ef72
chore: use generics for `querySelectorAll()`
gabrieljablonski Mar 16, 2024
4d445cd
chore: upgrade packages that are not major verion changes
danielbarion Mar 19, 2024
71ea615
chore: upgrade majors - rollup, rimraf, typescript
danielbarion Mar 19, 2024
305f536
chore: upgrade husky and dev dependencies majors
danielbarion Mar 19, 2024
d2d6bfd
chore: bump version to 6.0.0 in order of beta releases
danielbarion May 8, 2024
027a693
ci: raise node-version on beta-release workflow
danielbarion May 8, 2024
20bdb8c
ci: rename reserved word on higher node versions on strict mode
danielbarion May 8, 2024
da39d8e
ci: refactor beta-release.json to use import instead of require
danielbarion May 8, 2024
0e7324d
chore: upgrade packages on minor and patch versions
danielbarion May 9, 2024
d8b2444
chore: refactor CSS support logic and write tests for it
danielbarion Jul 16, 2024
b352e0c
chore: remove cssSupport util and his usage
danielbarion Jul 16, 2024
5eea310
chore: upgrade dev dependencies
danielbarion Jul 16, 2024
bee4f78
chore: upgrade dev dependencies pt.2
danielbarion Jul 16, 2024
bc0fbbe
chore: upgrade esbuild dependencie
danielbarion Jul 16, 2024
c819757
chore: upgrade rollup, husky, eslint and rimraf dev packages
danielbarion Jul 22, 2024
931ee2b
chore: improve the bundle size and .map generation
danielbarion Sep 26, 2024
a6e4d8a
test: add tests for get-scroll-parent.ts
danielbarion Sep 26, 2024
0a10f9f
test: update handle-style.ts logic and tests
danielbarion Sep 26, 2024
fef140b
test: update handle-style.ts tests to include legacy IE property
danielbarion Sep 26, 2024
2a2de20
test: add test for handle-style internal global state
danielbarion Sep 26, 2024
adbade5
test: should inject styles before the first child of head element at ...
danielbarion Sep 26, 2024
ca960b3
test: finish handle-style.ts at 100 coverage
danielbarion Sep 26, 2024
49064c6
test: create tooltip-controller test file
danielbarion Sep 26, 2024
786b9a1
test: achieve 100 test on TooltipController and remove unused tests
danielbarion Sep 27, 2024
7e5fea4
chore: update husky package version and remove old snapshot
danielbarion Sep 27, 2024
f099373
refactor: update isomorphic layout to check by document and create el...
danielbarion Sep 30, 2024
b35a7d0
test: write tests for useIsomorphicLayoutEffect
danielbarion Sep 30, 2024
1b21876
test: fix typo into variable name
danielbarion Sep 30, 2024
dd6d0ba
fix: update type to be optional on handle-style
danielbarion Sep 30, 2024
a945d0b
test: improve coverage to 97%
danielbarion Mar 11, 2025
4c63fa5
chore: add more cleanups to prevent memory leak
danielbarion Mar 11, 2025
02ff8c0
chore: add dependency array to useEffect on app.tsx (dev mode)
danielbarion Mar 11, 2025
27f8957
test: improve coverage to 98%
danielbarion Mar 11, 2025
acb09dd
refactor: update tests name
danielbarion Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .eslintrc.json
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,8 @@
"@typescript-eslint/ban-ts-comment": "off",
"dot-notation": "off",
"no-shadow": "off",
"@typescript-eslint/no-shadow": "error"
"@typescript-eslint/no-shadow": "error",
"react-hooks/rules-of-hooks": "error",
"react-hooks/exhaustive-deps": "warn"
}
}
2 changes: 1 addition & 1 deletion .github/workflows/beta-release.yaml
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
ref: ${{ github.head_ref }}
- uses: actions/setup-node@v4
with:
node-version: '16.x'
node-version: '18.x'
registry-url: 'https://registry.npmjs.org'
cache: 'yarn'

Expand Down
22 changes: 13 additions & 9 deletions beta-release.js
View file Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,17 @@
/* eslint-disable @typescript-eslint/no-var-requires */
const util = require('util')
const exec = util.promisify(require('child_process').exec)
const package = require('./package.json')
import util from 'util'
import { exec as execCallback } from 'child_process'
import minimist from 'minimist'
import pkg from './package.json' assert { type: 'json' }

const args = require('minimist')(process.argv.slice(2))
const exec = util.promisify(execCallback)

const args = minimist(process.argv.slice(2))

console.log({ args })

const issueNumber = args['issue']

console.log(issueNumber)
console.log({ issueNumber })

const runCommand = async (command) => {
return new Promise((resolve) => {
Expand All @@ -26,7 +30,7 @@ const AutoBetaRelease = async () => {

// check if there is a beta release with the same issue number on published versions
const arrayOfBetaReleases = JSON.parse(stdout).filter((version) =>
version.includes(`${package.version}-beta.${issueNumber}`),
version.includes(`${pkg.version}-beta.${issueNumber}`),
)

let fullLastBetaRelease = null
Expand Down Expand Up @@ -56,9 +60,9 @@ const AutoBetaRelease = async () => {
}

// next beta release version. Output: 1.0.0-beta.1.rc.1
const nextBetaReleaseVesionFull = `${package.version}-beta.${issueNumber}.rc.${nextBetaReleaseVersion}`
const nextBetaReleaseVesionFull = `${pkg.version}-beta.${issueNumber}.rc.${nextBetaReleaseVersion}`

// update the beta version on package.json
// update the beta version on packageJson.json
const { error } = await runCommand(
`npm version ${nextBetaReleaseVesionFull} --no-git-tag-version`,
)
Expand Down
9 changes: 6 additions & 3 deletions jest.config.ts
View file Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable max-len */
/*
* For a detailed explanation regarding each configuration property and type check, visit:
* https://jestjs.io/docs/configuration
Expand Down Expand Up @@ -25,8 +26,6 @@ export default {
// dev stuff
'!src/*',
'!src/**/*.d.ts',
// deprecated
'!src/components/TooltipProvider/*',
],

// The directory where Jest should output its coverage files
Expand Down Expand Up @@ -93,7 +92,10 @@ export default {
// ],

// A map from regular expressions to module names or to arrays of module names that allow to stub out resources with a single module
// moduleNameMapper: {},
moduleNameMapper: {
'^(\\.{1,2}/.*)\\.js$': '1ドル',
},
extensionsToTreatAsEsm: ['.ts'],

// An array of regexp pattern strings, matched against all module paths before considered 'visible' to the module loader
// modulePathIgnorePatterns: [],
Expand Down Expand Up @@ -184,6 +186,7 @@ export default {
'ts-jest',
{
tsconfig: 'tsconfig.json',
useESM: true,
},
],
'^.+\\.ts?$': [
Expand Down
124 changes: 62 additions & 62 deletions package.json
View file Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,24 @@
{
"name": "react-tooltip",
"version": "5.27.1",
"version": "6.0.0",
"description": "react tooltip component",
"scripts": {
"dev-rollup": "node ./prebuild.js --env=development && node --max_old_space_size=2048 ./node_modules/rollup/dist/bin/rollup -c rollup.config.dev.js --watch",
"build": "node ./prebuild.js --env=production && npm run types && node --max_old_space_size=2048 ./node_modules/rollup/dist/bin/rollup -c rollup.config.prod.js",
"dev-rollup": "node ./prebuild.js --env=development && node --max_old_space_size=2048 ./node_modules/rollup/dist/bin/rollup -c rollup.config.dev.mjs --watch",
"build": "node ./prebuild.js --env=production && npm run types && node --max_old_space_size=2048 ./node_modules/rollup/dist/bin/rollup -c rollup.config.prod.mjs",
"dev": "node ./prebuild.js --env=development && node ./esbuild.config.dev.mjs",
"build-esbuild": "node ./prebuild.js --env=production && node ./esbuild.config.prod.mjs",
"types": "node --max_old_space_size=2048 ./node_modules/rollup/dist/bin/rollup -c rollup.config.types.js",
"types": "node --max_old_space_size=2048 ./node_modules/rollup/dist/bin/rollup -c rollup.config.types.mjs",
"eslint": "eslint --ext=js --ext=jsx --ext=ts --ext=tsx --fix ./src",
"stylelint": "stylelint \"src/**/*.css\"",
"prettier": "prettier --config ./.prettierrc.json --write \"src/**/*{.js,.jsx,.ts,.tsx,.css}\"",
"prepare": "husky install",
"prepare": "husky",
"bundlesize": "bundlesize",
"esbuild": "esbuild",
"test": "jest",
"postbuild": "npm run types && npm run bundlesize",
"postbuild": "npm run types",
"prepublishOnly": "npm run build"
},
"type": "module",
"types": "dist/react-tooltip.d.ts",
"license": "MIT",
"private": false,
Expand Down Expand Up @@ -48,65 +49,64 @@
},
"homepage": "https://github.com/ReactTooltip/react-tooltip#readme",
"devDependencies": {
"@rollup/plugin-commonjs": "22.0.2",
"@rollup/plugin-node-resolve": "14.1.0",
"@rollup/plugin-replace": "4.0.0",
"@rollup/plugin-typescript": "8.5.0",
"@testing-library/jest-dom": "^5.16.5",
"@rollup/plugin-commonjs": "26.0.1",
"@rollup/plugin-node-resolve": "15.2.3",
"@rollup/plugin-replace": "5.0.7",
"@rollup/plugin-typescript": "11.1.6",
"@testing-library/jest-dom": "5.16.5",
"@testing-library/react": "12.1.5",
"@testing-library/user-event": "^14.4.3",
"@types/css": "^0.0.33",
"@types/css-modules": "^1.0.2",
"@types/jest": "29.4.0",
"@types/node": "^18.15.3",
"@types/react": "^18.2.17",
"@types/react-dom": "18.0.11",
"@types/react-test-renderer": "^18.0.0",
"@typescript-eslint/eslint-plugin": "5.54.0",
"@typescript-eslint/parser": "5.54.0",
"bundlesize": "^0.18.1",
"css-loader": "6.7.3",
"esbuild": "0.17.11",
"esbuild-css-modules-plugin": "^2.7.1",
"eslint": "8.35.0",
"@testing-library/user-event": "14.5.2",
"@types/css": "0.0.37",
"@types/css-modules": "1.0.5",
"@types/jest": "29.5.12",
"@types/node": "18.15.3",
"@types/react": "18.3.1",
"@types/react-dom": "18.3.0",
"@types/react-test-renderer": "18.3.0",
"@typescript-eslint/eslint-plugin": "7.16.1",
"@typescript-eslint/parser": "7.16.1",
"bundlesize": "0.18.2",
"css-loader": "6.10.0",
"esbuild": "0.23.0",
"esbuild-css-modules-plugin": "2.7.1",
"eslint": "8.57.0",
"eslint-config-airbnb": "19.0.4",
"eslint-config-prettier": "8.6.0",
"eslint-plugin-import": "2.27.5",
"eslint-plugin-jsx-a11y": "6.7.1",
"eslint-plugin-prettier": "^4.0.0",
"eslint-plugin-react": "7.32.2",
"eslint-plugin-react-hooks": "^4.2.0",
"husky": "8.0.3",
"jest": "29.4.3",
"jest-environment-jsdom": "29.4.3",
"eslint-config-prettier": "9.1.0",
"eslint-plugin-import": "2.29.1",
"eslint-plugin-jsx-a11y": "6.9.0",
"eslint-plugin-prettier": "5.2.1",
"eslint-plugin-react": "7.35.0",
"eslint-plugin-react-hooks": "4.6.2",
"husky": "9.1.6",
"jest": "29.7.0",
"jest-environment-jsdom": "29.7.0",
"jest-transform-css": "6.0.1",
"lint-staged": "13.1.2",
"minimist": "^1.2.8",
"postcss": "8.4.21",
"prettier": "2.8.4",
"process": "^0.11.10",
"lint-staged": "15.2.7",
"minimist": "1.2.8",
"postcss": "8.4.39",
"prettier": "3.3.3",
"process": "0.11.10",
"react": "16.14.0",
"react-dom": "16.14.0",
"rimraf": "^3.0.2",
"rollup": "2.79.1",
"rollup-plugin-analyzer": "^4.0.0",
"rollup-plugin-browsersync": "^1.3.3",
"rollup-plugin-copy": "^3.4.0",
"rollup-plugin-dts": "5.2.0",
"rollup-plugin-filesize": "^9.1.1",
"rollup-plugin-html-scaffold": "^0.2.0",
"rollup-plugin-postcss": "^4.0.1",
"rollup-plugin-progress": "^1.1.2",
"rollup-plugin-string": "^3.0.0",
"rollup-plugin-terser": "^7.0.2",
"rollup-plugin-visualizer": "5.9.0",
"style-loader": "^3.3.0",
"stylelint": "^13.13.1",
"stylelint-config-prettier": "^8.0.2",
"stylelint-config-standard": "^22.0.0",
"ts-jest": "29.0.5",
"ts-node": "^10.9.1",
"typescript": "4.9.5"
"rimraf": "6.0.1",
"rollup": "4.35.0",
"rollup-plugin-analyzer": "4.0.0",
"rollup-plugin-browsersync": "1.3.3",
"rollup-plugin-copy": "3.5.0",
"rollup-plugin-dts": "6.1.1",
"rollup-plugin-html-scaffold": "0.2.0",
"rollup-plugin-postcss": "4.0.1",
"rollup-plugin-progress": "1.1.2",
"rollup-plugin-string": "3.0.0",
"rollup-plugin-terser": "7.0.2",
"rollup-plugin-visualizer": "5.12.0",
"style-loader": "3.3.4",
"stylelint": "16.7.0",
"stylelint-config-prettier": "9.0.5",
"stylelint-config-standard": "36.0.1",
"ts-jest": "29.2.5",
"ts-node": "10.9.2",
"typescript": "5.4.5"
},
"peerDependencies": {
"react": ">=16.14.0",
Expand All @@ -125,7 +125,7 @@
]
},
"dependencies": {
"@floating-ui/dom": "^1.6.1",
"classnames": "^2.3.0"
"@floating-ui/dom": "1.6.13",
"clsx": "2.1.1"
}
}
6 changes: 3 additions & 3 deletions prebuild.js
View file Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
const fs = require('fs') // eslint-disable-line @typescript-eslint/no-var-requires
const rimraf = require('rimraf') // eslint-disable-line @typescript-eslint/no-var-requires
import fs from 'fs'
import { rimraf } from 'rimraf'

const args = process.argv.slice(2)
const parameters = args.reduce((acc, arg) => {
Expand All @@ -25,7 +25,7 @@ log(`Building for env: ${parameters.env}`)

// check if directory exists
if (fs.existsSync(dir)) {
rimraf(dir, () => {
rimraf(dir).then(() => {
fs.mkdirSync(dir)
})
} else {
Expand Down
3 changes: 1 addition & 2 deletions rollup.config.dev.js → rollup.config.dev.mjs
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ const name = 'ReactTooltip'
const globals = {
react: 'React',
'react-dom': 'ReactDOM',
classnames: 'classNames',
'prop-types': 'PropTypes',
clsx: 'clsx',
}

const plugins = [
Expand Down
22 changes: 16 additions & 6 deletions rollup.config.prod.js → rollup.config.prod.mjs
View file Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,21 @@
import commonjs from '@rollup/plugin-commonjs'
import filesize from 'rollup-plugin-filesize'
import postcss from 'rollup-plugin-postcss'
import progress from 'rollup-plugin-progress'
import replace from '@rollup/plugin-replace'
import { nodeResolve } from '@rollup/plugin-node-resolve'
import ts from '@rollup/plugin-typescript'
import { terser } from 'rollup-plugin-terser'
import typescript from 'typescript'
import { readFileSync } from 'fs'
import { fileURLToPath } from 'url'
import { dirname, resolve } from 'path'
import replaceBeforeSaveFile from './rollup-plugins/replace-before-save-file.js'
import * as pkg from './package.json'

const filename = fileURLToPath(import.meta.url)
const dirName = dirname(filename)

// Read package.json
const pkg = JSON.parse(readFileSync(resolve(dirName, './package.json'), 'utf8'))

const input = ['src/index.tsx']

Expand Down Expand Up @@ -39,8 +46,7 @@ const buildFormats = [
'@floating-ui/dom': 'FloatingUIDOM',
react: 'React',
'react-dom': 'ReactDOM',
classnames: 'classNames',
'prop-types': 'PropTypes',
clsx: 'clsx',
},
},
{
Expand All @@ -58,7 +64,7 @@ const sharedPlugins = [
replace({
preventAssignment: true,
values: {
'process.env.NODE_ENV': JSON.stringify('development'),
'process.env.NODE_ENV': JSON.stringify('production'),
},
}),
nodeResolve(),
Expand All @@ -76,7 +82,7 @@ const minifiedBuildFormats = buildFormats.map(({ file, ...rest }) => ({
file: file.replace(/(\.[cm]?js)$/, '.min1ドル'),
...rest,
minify: true,
plugins: [terser({ compress: { directives: false } }), filesize()],
plugins: [terser({ compress: { directives: false } })],
}))

const allBuildFormats = [...buildFormats, ...minifiedBuildFormats]
Expand Down Expand Up @@ -115,6 +121,10 @@ const config = allBuildFormats.map(
name,
globals,
sourcemap: true,
// Exclude the actual source content from the source map.
// This means that the source maps will contain references
// to positions in the original code, but not the source code itself.
sourcemapExcludeSources: true,
banner,
},
external,
Expand Down
File renamed without changes.
Loading

AltStyle によって変換されたページ (->オリジナル) /