Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Export #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
darryl-amour wants to merge 118 commits into React-Proto:master from Danger-Noodle:export
Closed

Export #85

darryl-amour wants to merge 118 commits into React-Proto:master from Danger-Noodle:export

Conversation

@darryl-amour
Copy link
Collaborator

@darryl-amour darryl-amour commented Jan 8, 2019

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

adriansun1 and others added 30 commits December 19, 2018 18:58
...aterial-ui/icons. Added those icons to the main-header-buttons palette. Added the methods to PropTypes validation.
...t listeners for ipcMain.on: save_workspace and open_workspace. Modified the electron menu and added 2 new submenu items under 'File'.
...patchToProps and mapStateToProps. Updated PropTypes validation. Updated render() to pass handler functions to MainContainerHeader. Added listening & emitting events to Electron IPC.
...MPORT_WORKSPACE. imported uitlity module for creating workspace file. added functions importWorkspace and exportWorkspace to implement proper dispatching of actions for Open Workspace and Save Workspace As feature.
... 3 functions from utils/componentReducer.util. Added 4 case statements to switch statement within componentReducer().
...the 'm' is capitalized. Changed hot key to be 'U' as updated in the Electron menus. Command to upload is now properly displayed.
...that is an aggregate compression of an image and the application state in JSON format.
darryl-amour and others added 28 commits January 2, 2019 18:48
...was mutating the workspace.comonent state without updating the Redux store.
...tore. Added parent and children to initialComponentState. convertIdsToObjs called for methods that return components: updateComponent, deleteComponent, deleteChild, addChild and reassignParent.
...parent and children properties of workspaceData.components[component] and workspaceData.focusComponent which is also an object reference. The outcome I called slimWorkspaceData and used that for serialization.
...lication using the convertIdsToObjs function. Also reassigned the workspaceData.focusComponent to be a legitimate object reference from workspaceData.components.
...omposition. Memory leak still present but Redux devtools can be used for a much longer period before crashing.
... addRoute, setSelectableR and setSelectableP. Reverted how setting component.visible property within setVisible method as Integration tests were failing as value was not being toggled.
...e.log, trimmed lines > 100, unused variable declarations, added required entries to PropTypes.
Copy link
Collaborator Author

Apologies, wrong repo.

darryl-amour reacted with confused emoji darryl-amour reacted with heart emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /