-
Couldn't load subscription status.
- Fork 230
Export #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Export #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create routes
...aterial-ui/icons. Added those icons to the main-header-buttons palette. Added the methods to PropTypes validation.
...evDependencies to a dependencies
...t listeners for ipcMain.on: save_workspace and open_workspace. Modified the electron menu and added 2 new submenu items under 'File'.
... prevent a null message being sent to React.
...patchToProps and mapStateToProps. Updated PropTypes validation. Updated render() to pass handler functions to MainContainerHeader. Added listening & emitting events to Electron IPC.
...uccess and error constants are no longer needed.
...MPORT_WORKSPACE. imported uitlity module for creating workspace file. added functions importWorkspace and exportWorkspace to implement proper dispatching of actions for Open Workspace and Save Workspace As feature.
...ght container works.
... 3 functions from utils/componentReducer.util. Added 4 case statements to switch statement within componentReducer().
...omise.all within createWorkspaceFile()
...the 'm' is capitalized. Changed hot key to be 'U' as updated in the Electron menus. Command to upload is now properly displayed.
...so it always displays.
...into routelist
...that is an aggregate compression of an image and the application state in JSON format.
Props Drilling Feature
Route list design
...was mutating the workspace.comonent state without updating the Redux store.
...roto into RouteListDesign
...into RouteListDesign
Route list design
...tore. Added parent and children to initialComponentState. convertIdsToObjs called for methods that return components: updateComponent, deleteComponent, deleteChild, addChild and reassignParent.
...parent and children properties of workspaceData.components[component] and workspaceData.focusComponent which is also an object reference. The outcome I called slimWorkspaceData and used that for serialization.
...lication using the convertIdsToObjs function. Also reassigned the workspaceData.focusComponent to be a legitimate object reference from workspaceData.components.
...omposition. Memory leak still present but Redux devtools can be used for a much longer period before crashing.
... addRoute, setSelectableR and setSelectableP. Reverted how setting component.visible property within setVisible method as Integration tests were failing as value was not being toggled.
Save open workspace
...e.log, trimmed lines > 100, unused variable declarations, added required entries to PropTypes.
...orkspace so they are properly saved.
...any existing background will be removed.
working props boilerplate export
Apologies, wrong repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
Types of changes
Checklist: