Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Remove Python 3.9 support and the legacy retworkx import #1509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IvanIsCoding wants to merge 9 commits into Qiskit:main
base: main
Choose a base branch
Loading
from IvanIsCoding:remove-39-retworkx

Conversation

@IvanIsCoding
Copy link
Collaborator

@IvanIsCoding IvanIsCoding commented Sep 21, 2025

In short, this PR:

  • Moves the build from 3.9 ABI to 3.10 ABI
  • Removes Python 3.9 from GitHub actions
  • Bumps Python in CI: 3.10->3.12 to avoid having to do bumps when 3.10 reaches EoL
  • Removes the legacy retworkx shim
  • Run tests with the Python 3.14 RC. I will add a release note for 3.14 once it's formally released and we are closer to the 0.18.0 release

Copy link

coveralls commented Sep 21, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 18793119002

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.186%
Totals Coverage Status
Change from base Build 18781234584: 0.0%
Covered Lines: 18272
Relevant Lines: 19400
💛 - Coveralls

Copy link
Collaborator Author

I bumped ruff to lint for Python 3.10 and it found some fixes that are only available for 3.10+.

Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this, I know we had previously discussed stopping retworkx releases in 1.0, but I think it's been long enough. Just a few inline questions. The only open question really is if we want to add 3.14 to the package metadata and test matrix in this PR or do it separately.

Copy link
Collaborator Author

I will address the comments on Saturday. I plan to add 3.14 support on a separate PR.

It will need some minor change for the MyPy stub tests. Right now, we are using a version that is pinned and might not support 3.14. At least I am confident there are no pre-compiled binaries for it (although MyPy ships a Python-only version)
mtreinish reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mtreinish mtreinish Awaiting requested review from mtreinish

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.18.0

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /