Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Feature/text extract #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Gonzom wants to merge 16 commits into PythonFreeCourse:develop
base: develop
Choose a base branch
Loading
from Gonzom:feature/text-extract

Conversation

@Gonzom
Copy link
Contributor

@Gonzom Gonzom commented Feb 25, 2021

Marking strings as translatable.

First pass, around 1/2 html files done.
Additionally some text strings were modified or removed.
One redundant file was also removed.

Gonzom added 12 commits February 14, 2021 19:12
First pass, around 1/2 html files done.
Additionally some text strings were modified or removed.
One redundant file was also removed.
...ract
# Conflicts:
#	app/templates/partials/user_profile/middle_content/event_card.html
...ract
# Conflicts:
#	app/templates/partials/user_profile/sidebar_left/profile_card/user_details.html
Copy link

Codecov Report

Merging #339 (883d957) into develop (9ace889) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@
## develop #339 +/- ##
===========================================
- Coverage 94.87% 94.87% -0.01% 
===========================================
 Files 83 83 
 Lines 3843 3842 -1 
===========================================
- Hits 3646 3645 -1 
 Misses 197 197 
Impacted Files Coverage Δ
app/routers/weekview.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ace889...883d957. Read the comment docs.

Gonzom added 4 commits March 30, 2021 20:48
Note: All of these files except 4 were not touched by me, but were failed by black. Any code changes should be discussed with the user(s) which committed them.
...re/text-extract
# Conflicts:
#	app/templates/partials/calendar/calendar_base.html
Copy link
Contributor Author

Gonzom commented Mar 30, 2021

Note: This fails and it has nothing to do with code I wrote. I'm not sure why some of the code does not get merged. I'm not going to continue fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yammesicka yammesicka yammesicka approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /