Feature/keyboard shortcuts #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

YairEn wants to merge 18 commits into PythonFreeCourse:develop

from YairEn:feature/keyboard-shortcuts

Open

Feature/keyboard shortcuts #160

YairEn wants to merge 18 commits into PythonFreeCourse:develop from YairEn:feature/keyboard-shortcuts

Conversation

@YairEn

Copy link

Contributor

@YairEn YairEn commented Jan 30, 2021

Keyboards shortcuts - New Feature:

New page of shortcuts explanation can be found by pressing on keyboard shortcuts button in profile page
The shortcuts that was added for now are navigation shortcuts to navigate between pages
I'm using the Mousetrap.js lib to catch the key press

YairEn added 9 commits

January 26, 2021 22:44

@YairEn


 add mousetrap lib to keys js files, and load js file in html

07fe63f

@YairEn


 Merge branch 'develop' into feature/keyboard-shortcuts

f9cc030

@YairEn


 Merge branch 'develop' into feature/keyboard-shortcuts

9813dfb

@YairEn


 Change shortcuts from home page to general

9aa7e78

remove bootstrap and js file from home_shortcuts
add test for router

@YairEn


 remove home test

ab47c1e

@YairEn


 Merge branch 'develop' into feature/keyboard-shortcuts

d70c329

@YairEn


 Change navigate to navigation

da42ebb

@YairEn


 delete profile_shortcuts.js file

9c29e96

@YairEn


 Fix - Pylint check - line too long

1cdbfd1

IdanPelled

IdanPelled reviewed

Jan 30, 2021

View reviewed changes

tests/test_keyboard_shortcuts_route.py Outdated Show resolved Hide resolved

yammesicka

yammesicka requested changes

Jan 31, 2021

View reviewed changes

Copy link

Member

@yammesicka yammesicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

Can you please add tests to the JS part?
You can use either Jest (the more popular one) or Cypress.

@YairEn


 Add test to test_keyboard_shortcuts_route.py

b257545

YairEn

YairEn commented

Jan 31, 2021

View reviewed changes

Copy link

Contributor Author

@YairEn YairEn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you yam!
Working now on js test:)

tests/test_keyboard_shortcuts_route.py Outdated Show resolved Hide resolved

@YairEn


 Add Cypress Test

3615ddc

ivarshav

ivarshav reviewed

Feb 5, 2021

View reviewed changes

app/main.py Outdated Show resolved Hide resolved

ivarshav

ivarshav reviewed

Feb 5, 2021

View reviewed changes

tests/test_keyboard_shortcuts_route.py Outdated Show resolved Hide resolved

yammesicka

yammesicka requested changes

Feb 10, 2021

View reviewed changes

Copy link

Member

@yammesicka yammesicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, there are some small improvement to do :) Keep up the good work

app/templates/profile.html Outdated Show resolved Hide resolved

app/templates/keyboard_shortcuts.html Outdated Show resolved Hide resolved

YairEn added 2 commits

February 23, 2021 03:45

@YairEn


 Merge branch 'develop' into feature/keyboard-shortcuts

5dba38f

Fix CR and conflicts

@YairEn


 Fix alphabetic order

f5e397d

@codecov-io

Copy link

codecov-io commented Feb 23, 2021 •

edited

Loading

Codecov Report

Merging #160 (c79bc08) into develop (b91708d) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@
## develop #160 +/- ##
===========================================
- Coverage 95.15% 95.11% -0.04% 
===========================================
 Files 76 77 +1 
 Lines 3382 3359 -23 
===========================================
- Hits 3218 3195 -23 
 Misses 164 164

Impacted Files	Coverage Δ
app/main.py	`92.68% <ø> (ø)`
app/routers/keyboard_shortcuts.py	`100.00% <100.00%> (ø)`
app/routers/salary/config.py	`100.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b91708d...b0a5938. Read the comment docs.

@YairEn

Copy link

Contributor Author

YairEn commented Feb 23, 2021

Yam, I am understand that we are not using cypress?
I did the tests but I talked to Lisaf and understand the his cypress ticket did not merged

@YairEn YairEn requested a review from yammesicka

February 23, 2021 10:06

@yammesicka

Copy link

Member

yammesicka commented Feb 23, 2021

I'm waiting for @Lisafiluz to resolve the conflicts there

yammesicka

yammesicka reviewed

Feb 23, 2021

View reviewed changes

Copy link

Member

@yammesicka yammesicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, added few insights

app/templates/home.html Outdated Show resolved Hide resolved

app/templates/keyboard_shortcuts.html Outdated Show resolved Hide resolved

app/templates/partials/user_profile/sidebar_left/features_card.html Outdated Show resolved Hide resolved

app/static/keyboard_shortcuts/general_shortcuts.js Outdated

'alt+c+p': function() { window.open('/profile/', '_self'); },

'alt+c+s': function() { window.open('/search/', '_self'); },

'alt+c+a': function() { window.open('/agenda/', '_self'); },

'ctrl+.': function() { window.open('/keyboard_shortcuts/', '_self'); }

Copy link

Member

@yammesicka yammesicka Feb 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you open this using modal instead? It's actually not too hard :)

Copy link

Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not understand, I need to open the page itself , not?
modal open a modal not the page, I need to navigate the user to the page he wanted
Thanks :)

Copy link

Member

@yammesicka yammesicka Feb 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better not to move the user to a whole new page, but to show him the keyboard shortcuts in the same page. Just like Jupyter Notebook does.

Copy link

Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, do you mean just the /keyboard_shortcuts to open like modal instead?

Copy link

Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I created Modal instead of page by using the button in profile page and It's definitely more beautiful, but I was not able to run it nicely by keyboard shortcut. so I removed that shortcut it for now.
All the ways that I found to do so, was by change the visibility (CSS) or using jQuery or JS but by change the button of the modal to use JS function instead.
If you know how to do so I'll be glad to hear

Copy link

Member

@yammesicka yammesicka Feb 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What have you tried?

Copy link

Contributor Author

@YairEn YairEn Feb 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$(#keyboard-shortcuts).modal('show') - It did not work
or just change the display of the element to block

Copy link

Member

@yammesicka yammesicka Feb 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not work because it assumes jQuery is imported (and also syntactically wrong - there are no quote signs wrapping #keyboard-shortcuts). Look at the relevant documentation of bootstrap 5, not 4

cypress/integration/keyboard_shortcuts_navigation.spec.js Show resolved Hide resolved

@YairEn


 Change indent to 2 spaces

c1c2743

Gonzom

Gonzom reviewed

Feb 24, 2021

View reviewed changes

app/templates/keyboard_shortcuts.html Outdated Show resolved Hide resolved

tests/test_keyboard_shortcuts_route.py Outdated Show resolved Hide resolved

YairEn added 4 commits

February 25, 2021 20:57

@YairEn


 Change keyboard_shortcuts to modal

b0a5938

@YairEn


 Remove keyboard_shortcuts.py

2973ec8

@YairEn


 Merge branch 'develop' into feature/keyboard-shortcuts

0c83116

@YairEn


 CHange U letter to u lowercase to check upload

91e50ce

@YairEn YairEn requested a review from yammesicka

February 25, 2021 20:50

Labels

None yet

6 participants

@YairEn @codecov-io @yammesicka @ivarshav @Gonzom @IdanPelled

Feature/keyboard shortcuts #160

Are you sure you want to change the base?

Feature/keyboard shortcuts #160

Uh oh!

Conversation

@YairEn YairEn commented Jan 30, 2021

Uh oh!

Uh oh!

@yammesicka yammesicka left a comment

Choose a reason for hiding this comment

Uh oh!

@YairEn YairEn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

@yammesicka yammesicka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov-io commented Feb 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

YairEn commented Feb 23, 2021

Uh oh!

yammesicka commented Feb 23, 2021

Uh oh!

@yammesicka yammesicka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

@yammesicka yammesicka Feb 23, 2021

Choose a reason for hiding this comment

Uh oh!

@YairEn YairEn Feb 23, 2021

Choose a reason for hiding this comment

Uh oh!

@yammesicka yammesicka Feb 23, 2021

Choose a reason for hiding this comment

Uh oh!

@YairEn YairEn Feb 24, 2021

Choose a reason for hiding this comment

Uh oh!

@YairEn YairEn Feb 24, 2021

Choose a reason for hiding this comment

Uh oh!

@yammesicka yammesicka Feb 25, 2021

Choose a reason for hiding this comment

Uh oh!

@YairEn YairEn Feb 25, 2021

Choose a reason for hiding this comment

Uh oh!

@yammesicka yammesicka Feb 26, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov-io commented Feb 23, 2021 •

edited

Loading