Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

WIP SpeedyMeetings2 #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
omrizhaki wants to merge 8 commits into PythonFreeCourse:develop
base: develop
Choose a base branch
Loading
from omrizhaki:feature/speedymeeting

Conversation

@omrizhaki
Copy link

@omrizhaki omrizhaki commented Jan 30, 2021

No description provided.

@omrizhaki omrizhaki changed the base branch from main to develop January 30, 2021 01:39

speedy_meetings_enabled = Column(Boolean, default=False)

def has_speedy_meetings_enabled(self) -> bool:
Copy link
Contributor

@sagizaidor sagizaidor Jan 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

מה המטרה שך הפנציה הזאת? למה לקרוא לה ולא פשוט לא user.speedy_meetings_enabled?


participants = relationship("UserEvent", back_populates="events")

def get_event_duration(self):
Copy link
Contributor

@sagizaidor sagizaidor Jan 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

זה דבר נהוג להכניס פונקציות לModels ולא להוציא את זה לקבצים בinternal?
בדקת את זה לפני?

שואל באמת כי זה פעם ראשונה שאני רואה

Copy link
Member

This is a good start :) Keep going

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sagizaidor sagizaidor sagizaidor left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /