-
Notifications
You must be signed in to change notification settings - Fork 67
WIP Add warning for mobile users attempting coding tutorials #620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Working on a banner to use on the landing page of coding tutorials and on the non-coding lessons that are sometimes included in coding tutorials. How do you feel about this concept, @zebateira? If we included messaging about both the JavaScript and the device, we could use it across the board on these to also help warn folks who don't know how to code. We could also cut up the text conditionally so that it only mentions the device if our media query suggests your device won't work.
on landing page of coding tutorial
on non-coding lesson w/in coding tutorial
image
Looking good 👍
Some concerns:
- Will it look too cramped when the a tutorial message shows up for new / updated tutorials? Would like to see that.
- Maybe it makes more sense to move the warning above the lesson title in the second case?
Uh oh!
There was an error while loading. Please reload this page.
Closes #147 by warning users with low res devices that they won't be able to complete coding challenges without a keyboard.
Currently this catches you on any lesson page within a tutorial (excluding landing page and resources) that contains coding challenges, even if the current lesson happens to be a quick text-based intro to upcoming content. Propose changing so the modal only appears on the coding lessons themselves and adding a separate non-modal banner to the landing page and any preliminary non-coding lessons so you know to expect the negative experience before getting started but can still see the page.