Assets/Infrastructure/Network/Configs/NetworkConfig.cs (3)

28-32: Harden inspector inputs for upload settings (add Min/Tooltip).

Prevent invalid values and improve UX by constraining and documenting the fields in the Inspector.

Apply this diff:

 [Header("File Upload Settings")]
-[SerializeField] private int maxFileSize = 10485760; // 10MB (bytes)
-[SerializeField] private float uploadTimeout = 60f; // 파일 업로드용 더 긴 타임아웃
-[SerializeField] private bool enableFileSizeCheck = true;
+[Tooltip("Maximum allowed file size in bytes (default 10MB).")]
+[Min(0)]
+[SerializeField] private int maxFileSize = 10485760; // 10MB (bytes)
+[Tooltip("Upload timeout in seconds (applies to form-data uploads).")]
+[Min(0.1f)]
+[SerializeField] private float uploadTimeout = 60f; // 파일 업로드용 더 긴 타임아웃
+[Tooltip("If true, client validates each file against MaxFileSize before upload.")]
+[SerializeField] private bool enableFileSizeCheck = true;

---

186-190: Expose units/semantics in XML docs for clarity.

Consider adding XML docs so call sites know units and behavior (bytes, seconds).

Apply this diff:

-// File Upload Settings
+// File Upload Settings
+/// <summary>Maximum allowed upload file size in bytes (per file).</summary>
 public static int MaxFileSize => Instance.maxFileSize;
+/// <summary>Timeout in seconds for form-data uploads.</summary>
 public static float UploadTimeout => Instance.uploadTimeout;
+/// <summary>When true, client-side enforcement of MaxFileSize is enabled.</summary>
 public static bool EnableFileSizeCheck => Instance.enableFileSizeCheck;

---

247-249: Defaults look sane. Consider using long if larger uploads are expected.

10MB/60s defaults are reasonable for voice. If future uploads may exceed 2GB, switch to long for file size.

Assets/Infrastructure/Audio/WavEncoder.cs (2)

14-39: AudioClip → PCM16 conversion is correct; consider edge-case refinements.

The implementation is solid. Two refinements to consider:

• Handle pathological inputs (NaN/Inf) defensively.
• Map -1.0f deterministically to short.MinValue (-32768) for symmetry.

Apply this diff:

- byte[] pcm16 = new byte[sampleCount * 2];
+ byte[] pcm16 = new byte[sampleCount * 2];
 int pcmIndex = 0;
 for (int i = 0; i < sampleCount; i++)
 {
- float clamped = Mathf.Clamp(samples[i], -1f, 1f);
- short s = (short)Mathf.RoundToInt(clamped * short.MaxValue);
+ var sample = samples[i];
+ if (float.IsNaN(sample) || float.IsInfinity(sample))
+ sample = 0f;
+ float clamped = Mathf.Clamp(sample, -1f, 1f);
+ // Map [-1, 1] to [-32768, 32767] with symmetric handling at -1
+ int scaled = (int)Mathf.Round(clamped * 32767f);
+ if (clamped <= -1f) scaled = short.MinValue;
+ short s = (short)scaled;
 pcm16[pcmIndex++] = (byte)(s & 0xFF);
 pcm16[pcmIndex++] = (byte)((s >> 8) & 0xFF);
 }

---

44-91: WAV header construction is correct; add basic parameter validation.

Guard against invalid channels/sampleRate to avoid malformed headers from upstream misuse.

Apply this diff:

 public static byte[] WrapPcm16ToWav(byte[] pcm16Data, int channels, int sampleRate)
 {
- if (pcm16Data == null || pcm16Data.Length == 0)
+ if (pcm16Data == null || pcm16Data.Length == 0)
 {
 return Array.Empty<byte>();
 }
+ if (channels <= 0) throw new ArgumentOutOfRangeException(nameof(channels), "Channels must be > 0.");
+ if (sampleRate <= 0) throw new ArgumentOutOfRangeException(nameof(sampleRate), "SampleRate must be > 0.");

Assets/Domain/Chat/View/VoiceInputView.cs (2)

301-308: Clamp progress and avoid toggling visibility on exact zero due to float jitter.

Small robustness tweak to keep UI clean and avoid flicker around 0.

Apply this diff:

 private void UpdateProgressBar(float progress)
 {
 if (_progressBar != null)
 {
- _progressBar.value = progress;
- _progressBar.gameObject.SetActive(progress > 0f);
+ var clamped = Mathf.Clamp01(progress);
+ _progressBar.value = clamped;
+ _progressBar.gameObject.SetActive(clamped > 0f);
 }
 }

---

243-251: Prefer dependency injection for STTService to keep the view testable.

Direct instantiation ties the view to a concrete implementation. Consider allowing a setter/injector to pass a mock or alternative implementation.

Apply this diff to enable an override while preserving current behavior:

- if (_sttService == null)
- {
- _sttService = new STTService();
- if (_sttService == null)
- {
- Debug.LogError("[VoiceInputView] STTService를 생성할 수 없습니다.");
- }
- }
+ if (_sttService == null)
+ {
+ _sttService = new STTService();
+ if (_sttService == null)
+ {
+ Debug.LogError("[VoiceInputView] STTService를 생성할 수 없습니다.");
+ }
+ }

And add this method outside the shown range (to support DI without breaking current calls):

public void SetSTTService(STTService sttService)
{
 _sttService = sttService;
}

Assets/Infrastructure/Network/Services/STTService.cs (1)

135-148: Unused DTOs taking up space

The STTRequest class is defined but never used in the implementation, as the service uses form data instead of JSON serialization.

Remove unused code:

-/// <summary>
-/// STT 요청 데이터 구조
-/// </summary>
-[Serializable]
-public class STTRequest
-{
- [JsonProperty("file")]
- public byte[] AudioData { get; set; } = new byte[0];
- 
- [JsonProperty("filename")]
- public string Filename { get; set; } = "recording.wav";
- 
- [JsonProperty("content_type")]
- public string ContentType { get; set; } = "audio/wav";
- 
- [JsonProperty("language")]
- public string Language { get; set; } = "ko";
-}

Assets/Infrastructure/Network/Http/HttpApiClient.cs (1)

518-520: Debug logging in production code

Extensive debug logging is left in production code paths, which can impact performance and expose sensitive information.

Use conditional compilation or a logging level system:

+#if UNITY_EDITOR || DEVELOPMENT_BUILD
 // 디버깅: Content-Type 헤더 확인
 string contentType = request.GetRequestHeader("Content-Type");
 Debug.Log($"[HttpApiClient] 요청 헤더 설정 완료 - Content-Type: {contentType}");
+#endif

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

Assets/Core/Audio/AudioRecorder.cs (2)

237-241: 녹음 중 마이크 변경 방지 구현됨

이전 리뷰에서 지적된 녹음 중 마이크 변경 문제가 올바르게 해결되었습니다.

---

53-64: Update() 메서드에서 매 프레임마다 불필요한 작업 수행

매 프레임마다 진행률 이벤트를 발생시키고 지속 시간을 체크하는 것은 비효율적입니다. UI 업데이트는 60+ FPS의 새로고침 빈도가 필요하지 않습니다.

업데이트 빈도를 제한하는 방식으로 개선하세요:

+private float _lastProgressUpdate = 0f;
+private const float PROGRESS_UPDATE_INTERVAL = 0.1f; // 초당 10회 업데이트
 private void Update()
 {
 if (_isRecording)
 {
- // 녹음 진행률 이벤트 발생
- OnRecordingProgress?.Invoke(RecordingProgress);
+ // 진행률 업데이트 제한
+ if (Time.time - _lastProgressUpdate >= PROGRESS_UPDATE_INTERVAL)
+ {
+ OnRecordingProgress?.Invoke(RecordingProgress);
+ _lastProgressUpdate = Time.time;
+ }
 
 // 최대 녹음 시간 체크
 if (RecordingDuration >= _maxRecordingLength)
 {
 StopRecording();
 }
 }
 }

Assets/Infrastructure/Network/Http/HttpApiClient.cs (2)

297-353: SendFormDataRequestAsync가 여전히 중복 구현을 포함하고 있습니다

이 메서드는 이전 리뷰에서 지적된 대로 fileNames 매개변수 처리만 다르고 나머지 로직이 동일합니다.

기본값 처리로 통합하는 현재 접근 방식(Line 299)이 올바른 방향이지만, 다른 오버로드를 제거해야 합니다. Line 88-92의 오버로드를 다음과 같이 수정하세요:

 public async UniTask<T> PostFormDataAsync<T>(string endpoint, Dictionary<string, object> formData, Dictionary<string, string> headers = null, CancellationToken cancellationToken = default)
 {
 var url = IsFullUrl(endpoint) ? endpoint : GetFullUrl(endpoint);
- return await SendFormDataRequestAsync<T>(url, formData, null, headers, cancellationToken);
+ return await PostFormDataAsync<T>(endpoint, formData, null, headers, cancellationToken);
 }

---

56-80: 중복된 요청 처리 로직을 통합하세요

SendJsonRequestAsync와 기존 SendRequestAsync 메서드가 재시도 로직, 에러 처리, 요청 처리 코드를 중복으로 구현하고 있습니다. 이는 유지보수 부담을 증가시킵니다.

단일 요청 핸들러로 통합하여 코드 중복을 제거하세요:

-private async UniTask<T> SendJsonRequestAsync<T>(string url, string method, string jsonData, Dictionary<string, string> headers, CancellationToken cancellationToken)
-{
- // ... 중복 구현
-}
-
-private async UniTask<T> SendRequestAsync<T>(string url, string method, string jsonData, Dictionary<string, string> headers, CancellationToken cancellationToken)
-{
- // ... 중복 구현 
-}
+private async UniTask<T> SendRequestAsync<T>(string url, string method, string jsonData, Dictionary<string, string> headers, bool useJsonContentType, CancellationToken cancellationToken)
+{
+ var combinedCancellationToken = CreateCombinedCancellationToken(cancellationToken);
+ 
+ for (int attempt = 0; attempt <= NetworkConfig.MaxRetryCount; attempt++)
+ {
+ try
+ {
+ using var request = useJsonContentType 
+ ? CreateJsonRequest(url, method, jsonData, headers)
+ : CreateRequest(url, method, jsonData, headers);
+ 
+ var operation = request.SendWebRequest();
+ await operation.WithCancellation(combinedCancellationToken);
+ 
+ if (request.result == UnityWebRequest.Result.Success)
+ {
+ return ParseResponse<T>(request);
+ }
+ else
+ {
+ await HandleRequestFailure(request, attempt, combinedCancellationToken);
+ }
+ }
+ catch (OperationCanceledException)
+ {
+ throw;
+ }
+ catch (Exception ex) when (ex is not ApiException)
+ {
+ await HandleRequestException(ex, attempt, combinedCancellationToken);
+ }
+ }
+ 
+ throw new ApiException($"{NetworkConfig.MaxRetryCount + 1}번 시도 후 요청 실패", 0, "최대 재시도 횟수 초과");
+}

그리고 호출 부분을 수정하세요:

 public async UniTask<T> GetAsync<T>(string endpoint, Dictionary<string, string> headers = null, CancellationToken cancellationToken = default)
 {
 var url = IsFullUrl(endpoint) ? endpoint : GetFullUrl(endpoint);
- return await SendJsonRequestAsync<T>(url, UnityWebRequest.kHttpVerbGET, null, headers, cancellationToken);
+ return await SendRequestAsync<T>(url, UnityWebRequest.kHttpVerbGET, null, headers, true, cancellationToken);
 }

Also applies to: 185-218

Assets/Core/Audio/AudioRecorder.cs (3)

103-103: null 안전성 개선 필요

_currentDevice가 null일 수 있는데 Microphone.Start에 빈 문자열을 전달하는 것은 명확하지 않습니다. Unity의 Microphone API는 null이나 빈 문자열을 기본 디바이스로 처리하지만, 이를 명시적으로 처리하는 것이 좋습니다.

-_recordingClip = Microphone.Start(_currentDevice ?? string.Empty, false, _maxRecordingLength, _sampleRate);
+// null 또는 빈 문자열은 기본 마이크 사용을 의미
+_recordingClip = Microphone.Start(_currentDevice, false, _maxRecordingLength, _sampleRate);

---

137-137: 일관성 있는 null 처리 패턴 사용

Line 103에서와 동일하게 _currentDevice에 대한 null 병합 연산자 사용이 불필요합니다.

-Microphone.End(_currentDevice ?? string.Empty);
+Microphone.End(_currentDevice);

---

319-322: DestroyImmediate 사용 시 주의사항

DestroyImmediate는 에디터와 런타임에서 모두 작동하지만, 런타임에서는 Destroy를 사용하는 것이 일반적입니다.

런타임과 에디터 컨텍스트를 구분하여 처리:

-if (_recordingClip != null)
-{
- DestroyImmediate(_recordingClip);
-}
+if (_recordingClip != null)
+{
+ #if UNITY_EDITOR
+ DestroyImmediate(_recordingClip);
+ #else
+ Destroy(_recordingClip);
+ #endif
+}

Assets/Infrastructure/Network/Http/HttpApiClient.cs (2)

427-443: CreateJsonRequest와 CreateRequest의 중복 코드

두 메서드의 유일한 차이점은 Content-Type 헤더 설정뿐입니다. 나머지 로직은 동일합니다.

단일 메서드로 통합하세요:

-private UnityWebRequest CreateRequest(string url, string method, string jsonData, Dictionary<string, string> headers)
-{
- var request = new UnityWebRequest(url, method);
- 
- if (!string.IsNullOrEmpty(jsonData))
- {
- var bodyRaw = Encoding.UTF8.GetBytes(jsonData);
- request.uploadHandler = new UploadHandlerRaw(bodyRaw);
- }
- 
- request.downloadHandler = new DownloadHandlerBuffer();
- SetupRequest(request, headers);
- request.timeout = (int)NetworkConfig.HttpTimeout;
- 
- return request;
-}
-
-private UnityWebRequest CreateJsonRequest(string url, string method, string jsonData, Dictionary<string, string> headers)
-{
- var request = new UnityWebRequest(url, method);
- 
- if (!string.IsNullOrEmpty(jsonData))
- {
- var bodyRaw = Encoding.UTF8.GetBytes(jsonData);
- request.uploadHandler = new UploadHandlerRaw(bodyRaw);
- request.SetRequestHeader("Content-Type", "application/json");
- }
- 
- request.downloadHandler = new DownloadHandlerBuffer();
- SetupRequest(request, headers);
- request.timeout = (int)NetworkConfig.HttpTimeout;
- 
- return request;
-}
+private UnityWebRequest CreateRequest(string url, string method, string jsonData, Dictionary<string, string> headers, bool setJsonContentType = false)
+{
+ var request = new UnityWebRequest(url, method);
+ 
+ if (!string.IsNullOrEmpty(jsonData))
+ {
+ var bodyRaw = Encoding.UTF8.GetBytes(jsonData);
+ request.uploadHandler = new UploadHandlerRaw(bodyRaw);
+ if (setJsonContentType)
+ {
+ request.SetRequestHeader("Content-Type", "application/json");
+ }
+ }
+ 
+ request.downloadHandler = new DownloadHandlerBuffer();
+ SetupRequest(request, headers);
+ request.timeout = (int)NetworkConfig.HttpTimeout;
+ 
+ return request;
+}

---

307-309: 프로덕션 환경에서 과도한 디버그 로깅

디버그 로그가 매 요청마다 출력되어 성능에 영향을 줄 수 있습니다.

조건부 로깅을 추가하거나 개발 환경에서만 활성화하세요:

+#if UNITY_EDITOR || DEVELOPMENT_BUILD
 Debug.Log($"[HttpApiClient] 폼 데이터 전송 시작 - URL: {url}");
 Debug.Log($"[HttpApiClient] 실제 전송 URL: {url}");
+#endif

Also applies to: 470-472

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro