Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

#7047: Nearest api returning node with id 0 #7048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
muteebali wants to merge 2 commits into Project-OSRM:master
base: master
Choose a base branch
Loading
from muteebali:bug/7047-Nearest-api-retruning-node-with-id-0

Conversation

@muteebali
Copy link

@muteebali muteebali commented Oct 4, 2024
edited
Loading

Issue

Bug: Nearest api returning node with id 0

Tasklist

  • Change the nearest_api.hpp code
  • Update ChangeLog.md

Snapshot of bug fix

FYI @jcoupey

Copy link

github-actions bot commented Apr 7, 2025

This PR seems to be stale. Is it still relevant?

Copy link

moboge commented Apr 7, 2025

@jcoupey any idea on when this PR can be merged into the master?

Copy link
Collaborator

i have this on my plate for the coming week.

moboge reacted with thumbs up emoji

Copy link
Collaborator

Change looks good to me. What we'd need is a test case that fails without this change and succeeds with it.

forward_geometry(phantom_node.fwd_segment_position - 1));
from_node = static_cast<std::uint64_t>(osm_node_id);
}
else if (phantom_node.fwd_segment_position == 0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this be more readable?

else if (phantom_node.forward_segment_id.enabled && phantom_node.fwd_segment_position == 0)
{
 // At the very beginning of a one-way forward geometry.
 // Segment runs from the first OSM node to the second OSM node.
 // We require at least 2 nodes in forward_geometry to form a valid edge.
 BOOST_ASSERT(forward_geometry.size() >= 2);
 auto from_osm_node = facade.GetOSMNodeIDOfNode(forward_geometry[0]);
 auto to_osm_node = facade.GetOSMNodeIDOfNode(forward_geometry[1]);
 from_node = static_cast<std::uint64_t>(from_osm_node);
 to_node = static_cast<std::uint64_t>(to_osm_node);
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@afarber afarber afarber requested changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /