- 
  Notifications
 
You must be signed in to change notification settings  - Fork 3.8k
 
#7047: Nearest api returning node with id 0 #7048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
 
  Open
 
 
 muteebali
 wants to merge
 2
 commits into
 Project-OSRM:master 
 
 
  
from
muteebali:bug/7047-Nearest-api-retruning-node-with-id-0 
 
 
 
  
 
 
 
 
 
 
 
 
 
 
  Open
 
 #7047: Nearest api returning node with id 0 #7048
 muteebali
 wants to merge
 2
 commits into
 Project-OSRM:master 
from
muteebali:bug/7047-Nearest-api-retruning-node-with-id-0 
 
 
 
  
 
 Conversation
 
 
 This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
 Learn more about bidirectional Unicode characters
 
 
 
 
 This PR seems to be stale. Is it still relevant?
 
 
 
 moboge
 
 
 
 commented
 Apr 7, 2025 
 
 
 
@jcoupey any idea on when this PR can be merged into the master?
i have this on my plate for the coming week.
Change looks good to me. What we'd need is a test case that fails without this change and succeeds with it.
 afarber
 
  
 
 
 afarber
 
 
 suggested changes
 
 
 Aug 29, 2025 
 
 
 
 
 
 
 
 
  forward_geometry(phantom_node.fwd_segment_position - 1));
 
 
  
 
 
  from_node = static_cast<std::uint64_t>(osm_node_id);
 
 
  
 
 
  }
 
 
  
 
 
  else if (phantom_node.fwd_segment_position == 0)
 
 
 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't this be more readable?
else if (phantom_node.forward_segment_id.enabled && phantom_node.fwd_segment_position == 0)
{
 // At the very beginning of a one-way forward geometry.
 // Segment runs from the first OSM node to the second OSM node.
 // We require at least 2 nodes in forward_geometry to form a valid edge.
 BOOST_ASSERT(forward_geometry.size() >= 2);
 auto from_osm_node = facade.GetOSMNodeIDOfNode(forward_geometry[0]);
 auto to_osm_node = facade.GetOSMNodeIDOfNode(forward_geometry[1]);
 from_node = static_cast<std::uint64_t>(from_osm_node);
 to_node = static_cast<std::uint64_t>(to_osm_node);
}
 
 Sign up for free
 to join this conversation on GitHub.
 Already have an account?
 Sign in to comment
 
 
 Add this suggestion to a batch that can be applied as a single commit.
 This suggestion is invalid because no changes were made to the code.
 Suggestions cannot be applied while the pull request is closed.
 Suggestions cannot be applied while viewing a subset of changes.
 Only one suggestion per line can be applied in a batch.
 Add this suggestion to a batch that can be applied as a single commit.
 Applying suggestions on deleted lines is not supported.
 You must change the existing code in this line in order to create a valid suggestion.
 Outdated suggestions cannot be applied.
 This suggestion has been applied or marked resolved.
 Suggestions cannot be applied from pending reviews.
 Suggestions cannot be applied on multi-line comments.
 Suggestions cannot be applied while the pull request is queued to merge.
 Suggestion cannot be applied right now. Please check back later.
 
 
 
 
Uh oh!
There was an error while loading. Please reload this page.
Issue
Bug: Nearest api returning node with id 0
Tasklist
Snapshot of bug fix
FYI @jcoupey