-
Notifications
You must be signed in to change notification settings - Fork 520
Fix #1177 - Added function-advanced snippet #1182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1177 - Added function-advanced snippet #1182
Conversation
CLA assistant check
All CLA requirements met.
timoline
commented
Feb 2, 2018
only renaming cmdlet and ex-cmdlet would fix this thing, or am I wrong?
This is practically identical to the existing cmdlet snippet. A number of the existing snippet names (including cmdlet) where taken from the ISE snippets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for contributing!
I opened an issue on vscode to support an array of prefixes so that we don't need two snippets:
microsoft/vscode#42838
but we wont block this PR on that.
Merged! Congrats on your 1st contribution @Benny1007!
microsoft/vscode#42838 is added,
snippits can be merged now
Added a function-advanced snippet based on the existing cmdlet snippet.
Leaves option to have more basic 'function' snippet based on the ISE 'function' snippet if required.
First PR, so grateful for further guidance.