Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Change "Open In ISE" shortcut #1117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

@TylerLeonhardt
Copy link
Member

@TylerLeonhardt TylerLeonhardt commented Dec 5, 2017

This changes the "Open In ISE" shortcut to ctrl+alt+i to address #1115.

Copy link
Contributor

@rkeithhill rkeithhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package.json looks good. Just curious why the Start-EditorServices.ps1 sig changed since it doesn't appear the script changed.

Copy link
Member Author

@rkeithhill it's the sig change from the 1.5.1 release. I just never updated the repo with it.

Copy link
Contributor

daviwil commented Dec 7, 2017

I think we're not supposed to be using Ctrl+Alt key combinations in VS Code since they can conflict with Windows shortcuts. Do you see any kind of errors in the Developer Tools console (Ctrl+Shift+I, check the Console tab) complaining about this shortcut?

TylerLeonhardt reacted with thumbs up emoji

Copy link
Member Author

@daviwil I changed it to shift+alt+p

Copy link
Member Author

Does that sound good to everyone

Copy link
Collaborator

Not sure how big of a deal it is, but it does conflict with a popular extension Project Manager. I wish we had some data on how often this is used. Having a default key bind for this when the extension was really early made sense, but I wonder if it's really needed these days.

Copy link
Member Author

@SeeminglyScience we could remove the functionality until someone complains :)

Copy link
Collaborator

@tylerl0706 I'm more suggesting the default key bind be removed until someone complains. The functionality would still available from the command palette. Though I suspect the folks still using the ISE may not be super used to the command palette.

rkeithhill reacted with thumbs up emoji

Copy link
Contributor

daviwil commented Jan 6, 2018

Actually, Patrick's suggestion makes sense to me. My feeling is that this keybinding isn't relevant for 90% of the PS extension users so we could safely remove it. If someone wants to bind this command to a key combo, they can do so very easily.

Copy link
Member Author

We were saying the same thing, I was just too vague :)

daviwil reacted with thumbs up emoji

Copy link
Contributor

Agreed. And if folks want to, they can bind the command to a shortcut of their choice. Then they can avoid stomping editor shortcuts they use.

Copy link
Member Author

Alright, I've removed the keybinding but you can still "Open in ISE" using the command pallet if you so choose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daviwil daviwil Awaiting requested review from daviwil

1 more reviewer

@rkeithhill rkeithhill rkeithhill approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /