-
Notifications
You must be signed in to change notification settings - Fork 520
Change "Open In ISE" shortcut #1117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change "Open In ISE" shortcut #1117
Conversation
fast forward
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
package.json looks good. Just curious why the Start-EditorServices.ps1 sig changed since it doesn't appear the script changed.
@rkeithhill it's the sig change from the 1.5.1 release. I just never updated the repo with it.
I think we're not supposed to be using Ctrl+Alt key combinations in VS Code since they can conflict with Windows shortcuts. Do you see any kind of errors in the Developer Tools console (Ctrl+Shift+I, check the Console tab) complaining about this shortcut?
@daviwil I changed it to shift+alt+p
Does that sound good to everyone
Not sure how big of a deal it is, but it does conflict with a popular extension Project Manager. I wish we had some data on how often this is used. Having a default key bind for this when the extension was really early made sense, but I wonder if it's really needed these days.
@SeeminglyScience we could remove the functionality until someone complains :)
@tylerl0706 I'm more suggesting the default key bind be removed until someone complains. The functionality would still available from the command palette. Though I suspect the folks still using the ISE may not be super used to the command palette.
Actually, Patrick's suggestion makes sense to me. My feeling is that this keybinding isn't relevant for 90% of the PS extension users so we could safely remove it. If someone wants to bind this command to a key combo, they can do so very easily.
We were saying the same thing, I was just too vague :)
Agreed. And if folks want to, they can bind the command to a shortcut of their choice. Then they can avoid stomping editor shortcuts they use.
Alright, I've removed the keybinding but you can still "Open in ISE" using the command pallet if you so choose.
This changes the "Open In ISE" shortcut to
ctrl+alt+ito address #1115.