Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[WiP] Add pester test for UnusedConnectionTimeout #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vthiebaut10 wants to merge 3 commits into PowerShell:latestw_all
base: latestw_all
Choose a base branch
Loading
from vthiebaut10:unused_connection_timeout_test

Conversation

@vthiebaut10
Copy link
Collaborator

@vthiebaut10 vthiebaut10 commented Feb 10, 2023

PR Summary

PR Context

@vthiebaut10 vthiebaut10 changed the title (削除) Add pester test for UnusedConnectionTimeout (削除ここまで) (追記) [WiP] Add pester test for UnusedConnectionTimeout (追記ここまで) Feb 10, 2023

# Start SSH process with Remote Forwarding Option to create a connection that doesn't prevent "Unused Connection Timeout"
$p = Start-Process -FilePath ssh -ArgumentList "-p $port -N -T -R 35000 $localuser1@$server" -PassThru
Wait-Process $p.Id -Timeout 10 -ErrorAction SilentlyContinue -ErrorVariable timeouted
Copy link

@PaulHigin PaulHigin Feb 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually put a wait action in a retry loop, so that the test will finish quicker if the timeout is around the expected 2 minutes (seconds?). The retry loop will retry to up to a maximum time to wait. Also we should try to let the test finish as soon as possible, is the 2 2 minutes or seconds?

vthiebaut10 reacted with thumbs up emoji
Copy link
Collaborator Author

@vthiebaut10 vthiebaut10 Feb 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's 2 seconds

PaulHigin reacted with thumbs up emoji
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@PaulHigin PaulHigin PaulHigin requested changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /