Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add the ability to use either . or & when launching script #2177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andyleejordan merged 1 commit into PowerShell:main from LucasArona:main
Oct 10, 2024

Conversation

@LucasArona
Copy link
Contributor

@LucasArona LucasArona commented Sep 9, 2024
edited by andyleejordan
Loading

Add support to change how the scripts are launched (DotSource vs Call operator).

PR Summary

Adds the ExecuteMode property and the corresponding method to either use the DotSource operator or the Call operator when launching scripts.

Related to this PR: (削除) PowerShell/vscode-powershell#5036 (削除ここまで) PowerShell/vscode-powershell#5059

PR Context

See PowerShell/vscode-powershell#4327

It's not always desirable to alter the current scope, this PR allows the use of the Call operator when launching scripts.

@andyleejordan andyleejordan changed the title (削除) Add the ability to use the Call operator instead of the DotSource operator (削除ここまで) (追記) Add the ability to use either . or & when launching script (追記ここまで) Oct 8, 2024
Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got this edited and fixed, merging in before pre-release.

Copy link
Member

@LucasArona I added a unit test for this too. About to merge if it all passes.

LucasArona reacted with hooray emoji

Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyleejordan andyleejordan added this pull request to the merge queue Oct 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 10, 2024
@andyleejordan andyleejordan added this pull request to the merge queue Oct 10, 2024
Merged via the queue into PowerShell:main with commit 6b4fb45 Oct 10, 2024
6 checks passed
@andyleejordan andyleejordan added the Issue-Enhancement A feature request (enhancement). label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andyleejordan andyleejordan andyleejordan approved these changes

@SeeminglyScience SeeminglyScience SeeminglyScience approved these changes

Assignees

No one assigned

Labels

Area-Debugging Issue-Enhancement A feature request (enhancement).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /