It looks like the build isn't working in CI for this PR

It builds fine on my Windows machine. 🤔

Seems GitHub actions builds on Ubuntu 22.04.

• https://github.com/PowerShell/PSResourceGet/actions/runs/16298810166/job/46027714439?pr=1846

Can it (Linux) even target net472?

Why the Windows Server 2022 build fails I don't know.

• https://dev.azure.com/powershell/PowerShellGet/_build/results?buildId=156008&view=logs&j=8b1bcd32-f438-5921-a69d-92ff85a481b1&t=1864767e-a38d-545a-f243-ec8cd3c81abd

It builds fine on my (Windows) machine as well, but I just pulled in your most recent changes and it's (still) not building on the server. We only build on windows, and then we use that build to test Windows PowerShell on Windows and PowerShell Core on Windows, Mac and Ubuntu.

Could you try opening up a new PR with a subset of these changes? It may help to have a smaller set of changes

Could we get more output on what/where it fails? dotnet.exe will create log files, right?

@adityapatwardhan's change resolved the build issue (just an incorrect file name), but it looks like many of the tests are failing with the same error:

Error parsing server metadata: Could not load file or assembly
| 'System.IO.Pipelines, Version=9.0.0.6, Culture=neutral,
| PublicKeyToken=cc7b13ffcd2ddd51'. The system cannot find the file
| specified.

Maybe previous run results are deleted, but the one failed test I can see does not fail when testing manually from Windows PowerShell.

• https://dev.azure.com/powershell/PowerShellGet/_build/results?buildId=156016&view=ms.vss-test-web.build-test-results-tab

The name of the failed test was misleading though, find resource given CommandName, while it actually was finding module by module name. I updated the name.

Can this be rerun and can I get some logs to see where and what it fails on?

I think this PR will need to be broken down to smaller PRs to see what's causing this issue:

Find-PSResource: D:\a1円\s\test\FindPSResourceTests\FindPSResourceContainerRegistryServer.Tests.ps1:76
[-] Find all versions of resource when given specific Name, Version not null --> '' 486ms
Line |
Expected a value, but got $null or empty.
76 | ... $res = Find-PSResource -Name $testModuleName -Version "" -Repos ...
77: $res | Should -Not -BeNullOrEmpty
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
at , D:\a1円\s\test\FindPSResourceTests\FindPSResourceContainerRegistryServer.Tests.ps1: line 77
| Error parsing server metadata: Could not load file or assembly 'System.IO.Pipelines, Version=9.0.0.8,
| Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'. The system cannot find the file specified.
Find-PSResource: D:\a1円\s\test\FindPSResourceTests\FindPSResourceContainerRegistryServer.Tests.ps1:87

It's very slow to troubleshoot when tests don't run on PR automatically. 🫠

I think it was due to upgrading System.Text.Json from v8 to v9, which requires dotnet 9.

Unfortunately now the package build is failing:

VERBOSE: Invoking build script
VERBOSE: Starting DoBuild for Microsoft.PowerShell.PSResourceGet with configuration: Release, framework: net472
VERBOSE: Module output file path: 'D:\a1円\s\out\Microsoft.PowerShell.PSResourceGet'
VERBOSE: Module build source path: 'D:\a1円\s\src\code\bin\Release\net472\publish'
VERBOSE: Building assembly and copying to 'D:\a1円\s\out\Microsoft.PowerShell.PSResourceGet'
VERBOSE: dotnet.exe command found in path: C:\hostedtoolcache\windows/dotnet\dotnet.exe
VERBOSE: DotNet version: 8.0.414
VERBOSE: Build location: PSScriptRoot: D:\a1円\s, PWD: D:\a1円\s\src\code
VERBOSE: Starting dotnet build command: dotnet.exe publish --configuration Release --framework net472 --output D:\a1円\s\src\code\bin\Release\net472\publish
VERBOSE: dotnet build failed with error: Build failed with exit code: 1
Invoke-ModuleBuild : Exception calling "Invoke" with "0" argument(s): "The running command stopped because the preference variable "ErrorActionPreference" or common parameter is set to Stop: dotnet build failed with error: Build failed with exit code: 1"
At D:\a1円\s\build.ps1:81 char:5
+ Invoke-ModuleBuild -BuildScript $sb
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo : NotSpecified: (:) [Invoke-ModuleBuild], MethodInvocationException
+ FullyQualifiedErrorId : ActionPreferenceStopException,Invoke-ModuleBuild
##[error]PowerShell exited with code '1'.
Finishing: Build Module

It builds fine on my machine, using dotnet v8.0.414. Would be helpful with more verbose build logs.

If you don't want to continue with this PR just close it. Would be nice to have it working and merged, though.