iOS 15 support #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

chamira-at wants to merge 6 commits into Polidea:master

from chamira-at:ios-15-support

Open

iOS 15 support #401

chamira-at wants to merge 6 commits into Polidea:master from chamira-at:ios-15-support

Conversation

@chamira-at

Copy link

@chamira-at chamira-at commented Sep 2, 2021

There are some changes to the Core Bluetooth API.

CBService
unowned(unsafe) var peripheral: CBPeripheral { get }
CBCharacteristic
unowned(unsafe) var service: CBService { get }
CBDescriptor
unowned(unsafe) var characteristic: CBCharacteristic { get }
iOS 15.X
CBService
weak var peripheral: CBPeripheral? { get }
CBCharacteristic
weak var service: CBService? { get }
CBDescriptor
weak var characteristic: CBCharacteristic? { get }

The changes are detailed describe here in this issue

Solution:

Made below classes' convenience init(...) methods optional convenience init?(...) and only initialize if pass in params required properties(service, characteristic, descriptors) are not deallocated.

RxBluetoothKit
- Characteristic.swift
- Descriptor.swift

Example

 convenience init?(descriptor: CBDescriptor, peripheral: Peripheral) {
 guard let _characteristic = descriptor.characteristic, let _service = _characteristic.service else {
 return nil
 }
 let service = Service(peripheral: peripheral, service: _service)
 let characteristic = Characteristic(characteristic: _characteristic, service: service)
 self.init(descriptor: descriptor, characteristic: characteristic)
 }

Caller sites have been always guard strogeRefeance therefore, added an extra guard for those that are optionally initializable.

Test

Test cases are update and force unwrapped for those optional initializable objects.

Other improvement

Fixed deprecated method signature warnings.

chamira-at added 3 commits

September 1, 2021 18:26

@chamira-at


 Fixed deprecated methods by replacing the with new method signatures ...

e02bb01

...(fixed warning)

@chamira-at


 Fixed warning ManagerType deprecated protocol class type

5e40d07

@chamira-at


 Support for iOS 15

b24a4ff

There are some changes to the CoreBluetooth API. Specially to the memory managment
Details are described here
Polidea#398

@CLAassistant

Copy link

CLAassistant commented Sep 2, 2021 •

edited

Loading

CLA assistant check
All committers have signed the CLA.

@chamira-at


 Revert "Fixed deprecated methods by replacing the with new method sig...

223f6b6

...natures (fixed warning)"
This reverts commit e02bb01.

@chamira-at chamira-at marked this pull request as ready for review

September 3, 2021 07:34

robnadin

robnadin reviewed

Sep 20, 2021

View reviewed changes

Source/CentralManagerRestoredState.swift Outdated Show resolved Hide resolved

robnadin

robnadin reviewed

Sep 20, 2021

View reviewed changes

Tests/PeripheralTest+CharacteristicOperation.swift Outdated Show resolved Hide resolved

chamira-at added 2 commits

September 20, 2021 22:35

@chamira-at


 Replace unnecessary chaining sequence of .map with compactMap

7c5731f

@chamira-at


 Change force unrwapping in XCTest Classes to XCTUnwrap

086f459

@CSolanaM

Copy link

CSolanaM commented Sep 23, 2021 •

edited

Loading

Thank you very much @chamira-at for this PR. A dependency of my project depends on this to unblock me of using the latest Swift version. Looking forward for @robnadin 's review.