Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Upgrade all dependencies #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Naramsim merged 2 commits into PokeAPI:master from lbineau:master
Sep 4, 2024
Merged

Upgrade all dependencies #58

Naramsim merged 2 commits into PokeAPI:master from lbineau:master
Sep 4, 2024

Conversation

@lbineau
Copy link

@lbineau lbineau commented Aug 29, 2024

There are a lot of security issues raised by this package so I've upgraded all dependencies.
Only chai packages couldn't be upgraded to the latest major version because it is using ESM. I only sticked with the latest minor version.
I've npm run test and npm run build and everything seems to work.

Naramsim and climaxmba reacted with thumbs up emoji
Copy link
Member

Hi, could you also bump the patch version of the package?

lbineau reacted with thumbs up emoji

@Naramsim Naramsim merged commit 2a691f9 into PokeAPI:master Sep 4, 2024
Copy link
Member

Naramsim commented Sep 4, 2024

Thanks!

Naramsim referenced this pull request Sep 6, 2024
Copy link
Member

Naramsim commented Sep 6, 2024

Hi! A user seems to have a problem with this version 1.2.5, @isackender. Coul it be possible that the package is broken?

Preventively I unpublished the 1.2.5 from NPM. Still the lib can be found in this GH repo under the dist folder.

Copy link

isackender commented Sep 6, 2024
edited
Loading

Hi, yes, as @Naramsim pointed out, my project broke two days ago. My code is:

<script src="https://unpkg.com/pokeapi-js-wrapper@1.2.5/dist/index.js"></script>
<!-- Service worker -->
<script src="pokeapi-js-wrapper-sw.js"></script>
<!-- Initialize js wrapper -->
<script>
 const customOptions = {
 protocol: "https",
 versionPath: "/api/v2/",
 cache: true,
 timeout: 5 * 1000, // 5s
 cacheImages: true
 };
 const P = new Pokedex.Pokedex(customOptions);
</script>
<!-- Project code -->
<script src="/scripts/main.js"></script>

Which gives me this error (using Firefox):

Uncaught ReferenceError: require is not defined
 23 https://unpkg.com/pokeapi-js-wrapper@1.2.5/dist/index.js:2
 n https://unpkg.com/pokeapi-js-wrapper@1.2.5/dist/index.js:2
 801 https://unpkg.com/pokeapi-js-wrapper@1.2.5/dist/index.js:2
 n https://unpkg.com/pokeapi-js-wrapper@1.2.5/dist/index.js:2
 737 https://unpkg.com/pokeapi-js-wrapper@1.2.5/dist/index.js:2
 n https://unpkg.com/pokeapi-js-wrapper@1.2.5/dist/index.js:2
 <anonymous> https://unpkg.com/pokeapi-js-wrapper@1.2.5/dist/index.js:2
 <anonymous> https://unpkg.com/pokeapi-js-wrapper@1.2.5/dist/index.js:2
 <anonymous> https://unpkg.com/pokeapi-js-wrapper@1.2.5/dist/index.js:2
 <anonymous> https://unpkg.com/pokeapi-js-wrapper@1.2.5/dist/index.js:2
 <anonymous> https://unpkg.com/pokeapi-js-wrapper@1.2.5/dist/index.js:2
index.js:2:61271

When I switch to a previous version it works again perfectly (1.2.3 or 1.2.4 work fine).

<script src="https://unpkg.com/pokeapi-js-wrapper@1.2.3/dist/index.js"></script>

Copy link
Contributor

climaxmba commented Sep 6, 2024
edited
Loading

Hi, yes, as @Naramsim pointed out, my project broke two days ago. My code is:

<script src="https://unpkg.com/pokeapi-js-wrapper@1.2.5/dist/index.js"></script>
<!-- Service worker -->
<script src="pokeapi-js-wrapper-sw.js"></script>
<!-- Initialize js wrapper -->
<script>
 const customOptions = {
 protocol: "https",
 versionPath: "/api/v2/",
 cache: true,
 timeout: 5 * 1000, // 5s
 cacheImages: true
 };
 const P = new Pokedex.Pokedex(customOptions);
</script>
<!-- Project code -->
<script src="/scripts/script.js"></script>

Which gives me this error (using Firefox):

Uncaught ReferenceError: require is not defined
 23 https://unpkg.com/pokeapi-js-wrapper@1.2.5/dist/index.js:2
 n https://unpkg.com/pokeapi-js-wrapper@1.2.5/dist/index.js:2
 801 https://unpkg.com/pokeapi-js-wrapper@1.2.5/dist/index.js:2
 n https://unpkg.com/pokeapi-js-wrapper@1.2.5/dist/index.js:2
 737 https://unpkg.com/pokeapi-js-wrapper@1.2.5/dist/index.js:2
 n https://unpkg.com/pokeapi-js-wrapper@1.2.5/dist/index.js:2
 <anonymous> https://unpkg.com/pokeapi-js-wrapper@1.2.5/dist/index.js:2
 <anonymous> https://unpkg.com/pokeapi-js-wrapper@1.2.5/dist/index.js:2
 <anonymous> https://unpkg.com/pokeapi-js-wrapper@1.2.5/dist/index.js:2
 <anonymous> https://unpkg.com/pokeapi-js-wrapper@1.2.5/dist/index.js:2
 <anonymous> https://unpkg.com/pokeapi-js-wrapper@1.2.5/dist/index.js:2
index.js:2:61271

When I switch to a previous version it works again perfectly (1.2.3 or 1.2.4 work fine).

<script src="https://unpkg.com/pokeapi-js-wrapper@1.2.3/dist/index.js"></script>

I've seen something like this when I was using a React package. Uninstalling or downgrading the broken dependency in this package should fix it.

Copy link
Member

Naramsim commented Sep 6, 2024

I remember I had issues upgrading axios, because maybe it became a pure ESM package. Maybe that's the issue

Copy link
Author

lbineau commented Sep 9, 2024
edited
Loading

@Naramsim @climaxmba @isackender,
After spending hours trying to understand why it outputs require in the UMD module and trying various config, I think I understood the issue.

Removing target: 'node' or switching it to target: 'web' properly remove any node related code (require()) and make it work properly.

Is this package supposed to be used in Node/browser/both?
I'll be happy to create PR if it is supposed to work with browsers only.

Error target: 'node'
node target showing a console error: require is undefined

Success target: 'web'
web target showing a console.log success

isackender and climaxmba reacted with heart emoji

Copy link
Contributor

climaxmba commented Sep 9, 2024
edited
Loading

Sure @lbineau, this package is meant for the browser only. There is a different package that's meant for Node.

Naramsim reacted with thumbs up emoji

Copy link
Author

lbineau commented Sep 9, 2024

Here you go #61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /