-
Notifications
You must be signed in to change notification settings - Fork 293
chore: Fix bug in CodeSnippets component #988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sserrata
merged 1 commit into
PaloAltoNetworks:main
from
aoki-atsushi:fix-empty-languageTabs-bug
Oct 7, 2024
Merged
chore: Fix bug in CodeSnippets component #988
sserrata
merged 1 commit into
PaloAltoNetworks:main
from
aoki-atsushi:fix-empty-languageTabs-bug
Oct 7, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CodeSnippets component had a bug where the condition for checking the selectedVariant was incorrect. This commit fixes the bug by adding a null check for the language variant.
@aoki-atsushi
aoki-atsushi
temporarily deployed
to
default
October 7, 2024 06:16 — with
GitHub Actions
Inactive
Visit the preview URL for this PR (updated for commit 7dfa13b):
https://docusaurus-openapi-36b86--pr988-9b910rnr.web.app
(expires 2024年11月06日 13:50:04 GMT)
🔥 via Firebase Hosting GitHub Action 🌎
Sign: bf293780ee827f578864d92193b8c2866acd459f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Description
The CodeSnippets component had a bug where the condition for checking the selectedVariant was incorrect. This commit fixes the bug by adding a null check for the language variant.
Motivation and Context
An error occurs in the CodeSnippets component when languageTabs is empty in
docusaurus.config.ts.Previously, CodeSnippets was not rendered.
How Has This Been Tested?
I set languageTabs to empty and confirmed that it was rendering the same as before without any errors in local.
Screenshots (if appropriate)
Before revision
image
After revision
image
Types of changes
Checklist