-
Notifications
You must be signed in to change notification settings - Fork 294
Fix change type of Show optional parameters button #969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sserrata
merged 1 commit into
PaloAltoNetworks:main
from
tuanpt-0634:fix_button_show_optional_parameters
Sep 17, 2024
Merged
Fix change type of Show optional parameters button #969
sserrata
merged 1 commit into
PaloAltoNetworks:main
from
tuanpt-0634:fix_button_show_optional_parameters
Sep 17, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid submitting form test api
@tuanpt-0634
tuanpt-0634
temporarily deployed
to
default
September 17, 2024 08:18 — with
GitHub Actions
Inactive
Thanks for the contribution @tuanpt-0634! Sometimes one line of code can make all the difference. 🥇
Visit the preview URL for this PR (updated for commit bab3b6b):
https://docusaurus-openapi-36b86--pr969-3bhrladz.web.app
(expires 2024年10月17日 13:06:32 GMT)
🔥 via Firebase Hosting GitHub Action 🌎
Sign: bf293780ee827f578864d92193b8c2866acd459f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Description
Fix #798
Motivation and Context
The button
Show optional parametersis in a form, so it's type is default tosubmit.
image
Since, we don't want to submit form in this case, we need to change button type to
button.How Has This Been Tested?
Tested on local env
Screenshots (if appropriate)
To reproduce
docusaurus-openapi-submit-bug-win.mp4
This can be reproduced on https://docusaurus-openapi.tryingpan.dev/cos/list-buckets
After fixed
docusaurus-openapi-submit-bug-fixed-win.mp4
Types of changes
Checklist