Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Add allOf required spec and fix items branch #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

@sserrata
Copy link
Member

@sserrata sserrata commented Jul 1, 2025

Description

Added a new OpenAPI example allOfRequired.yaml showing how a parent schema marks the pet property as required while composing its definition with allOf

Updated the SchemaEdge component so that all allOf branches check the incoming required prop, ensuring required flags are inherited correctly. SchemaNodeDetails is now returned when allOf items contain properties

Motivation and Context

Addresses #1163

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

@sserrata sserrata self-assigned this Jul 1, 2025
@sserrata sserrata added the bug Something isn't working label Jul 1, 2025
Copy link

github-actions bot commented Jul 1, 2025 •
edited
Loading

Visit the preview URL for this PR (updated for commit 2e9391c):

https://docusaurus-openapi-36b86--pr1190-rdklth2h.web.app

(expires 2025年8月01日 00:15:20 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: bf293780ee827f578864d92193b8c2866acd459f

Copy link

github-actions bot commented Jul 1, 2025

Visual Diff Summary

View Logs

Total: 76, Matches: 0, Diffs: 76, Skipped: 0

Page Status
/tests/all-of-with-array-items diff
/tests/additionalproperties-variations-api diff
/tests/all-of-with-nested-all-of diff
/tests/all-of-with-deep-merging diff
/tests/all-of-with-properties-in-array-item diff
/tests/allof-variations-api diff
/tests/all-of-with-same-level-properties diff
/tests/all-of-with-shared-required-properties diff
/tests/any-of-with-one-of diff
/tests/any-of-with-primitives diff
/tests/any-of-with-properties-in-array-item diff
/tests/anyof-variations-api diff
/tests/basic-discriminator-with-mapping diff
/tests/const diff
/tests/basic-discriminator-without-mapping diff
/tests/const-with-primitives diff
/tests/discriminator-variations-api diff
/tests/discriminator-with-all-of-without-mapping diff
/tests/discriminator-with-all-of-and-mapping diff
/tests/discriminator-with-mapping-and-no-shared-properties diff
/tests/discriminator-with-nested-schemas-and-mapping diff
/tests/discriminator-with-required-properties-and-mapping diff
/tests/discriminator-with-nested-schemas-without-mapping diff
/tests/discriminator-with-required-properties-without-mapping diff
/tests/discriminator-with-shared-properties-and-mapping diff
/tests/discriminator-with-shared-properties-without-mapping diff
/tests/discriminator-with-subschema-inheriting-all-fields-no-extra-fields diff
/tests/enum-descriptions-test diff
/tests/get-document-with-header-parameter diff
/tests/get-entities-by-multiple-status diff
/tests/get-item-by-id-label-style diff
/tests/get-entities-by-status diff
/tests/get-user-by-id diff
/tests/get-product-by-code-matrix-style diff
/tests/get-user-preferences-with-cookie-parameter diff
/tests/get-with-cookie-parameters diff
/tests/get-with-header-parameters diff
/tests/multiple-all-of-with-nested-properties diff
/tests/object-with-boolean-additional-properties diff
/tests/object-with-schema-defined-additional-properties diff
/tests/object-with-typed-additional-properties diff
/tests/object-without-any-additional-properties diff
/tests/one-of-with-complex-types diff
/tests/one-of-with-nested-one-of diff
/tests/one-of-with-primitive-types diff
/tests/one-of-with-properties-in-array-item diff
/tests/one-of-with-shared-properties diff
/tests/one-of-with-required-properties diff
/tests/oneof-variations-api diff
/tests/parameter-serialization-demo-api diff
/tests/schemas/additionalbookinfo diff
/tests/schemas/baseallof diff
/tests/schemas/basebasic diff
/tests/schemas/basebasicmapping diff
/tests/schemas/baseallofmapping diff
/tests/schemas/baseemptysubschema diff
/tests/schemas/basenested diff
/tests/schemas/baserequired diff
/tests/schemas/baserequiredmapping diff
/tests/schemas/basenestedmapping diff
/tests/schemas/baseshared diff
/tests/schemas/basesharedmapping diff
/tests/schemas/basesharedmappingnoproperties diff
/tests/schemas/book diff
/tests/schemas/bookbase diff
/tests/schemas/categorizedbook diff
/tests/schemas/emptytype diff
/tests/schemas/enumdescriptionsentity diff
/tests/schemas/existingschema-1 diff
/tests/schemas/existingschema-2 diff
/tests/schemas/nestedadditionalproperty diff
/tests/schemas/nestedtypea diff
/tests/schemas/nestedtypeb diff
/tests/schemas/typeb diff
/tests/schemas/typea diff
/tests/search-with-various-query-parameter-styles diff

@sserrata sserrata force-pushed the codex/refactor-schemaedge-to-use-required-prop branch from 5ab003b to 2e9391c Compare July 2, 2025 00:11
Copy link

github-actions bot commented Jul 2, 2025

Visual Diff Summary

View Logs

Total: 76, Matches: 73, Diffs: 3, Skipped: 0

Page Status
/tests/all-of-with-nested-all-of diff
/tests/allof-variations-api diff
/tests/anyof-variations-api diff

@sserrata sserrata merged commit 79e1962 into PaloAltoNetworks:main Jul 2, 2025
10 checks passed
@sserrata sserrata deleted the codex/refactor-schemaedge-to-use-required-prop branch July 2, 2025 13:42
dsuket pushed a commit to dsuket/docusaurus-openapi-docs that referenced this pull request Oct 13, 2025 
* Add allOf required spec and fix items branch
* Place allOfRequired example in allOf category
* move test to allOf
* Remove duplicate allOfRequired spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /